Issue 11413088: Merge 134577 - Web Inspector: highlight is not updating as one edits CSS properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11413088: Merge 134577 - Web Inspector: highlight is not updating as one edits CSS properties (Closed)

Created:
8 years, 1 month ago by pfeldman

Modified:
8 years, 1 month ago

Reviewers:
pfeldman

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Visibility:
Public.

More Reviews

Description

Merge 134577 - Web Inspector: highlight is not updating as one edits CSS properties https://bugs.webkit.org/show_bug.cgi?id=102191 Reviewed by Alexander Pavlov. We should update highlight upon layout / style recalculation. * inspector/InspectorInstrumentation.cpp: (WebCore): (WebCore::InspectorInstrumentation::didRecalculateStyleImpl): * inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::InspectorPageAgent): (WebCore::InspectorPageAgent::enable): (WebCore::InspectorPageAgent::disable): (WebCore::InspectorPageAgent::domContentEventFired): (WebCore::InspectorPageAgent::didPaint): (WebCore::InspectorPageAgent::didLayout): (WebCore::InspectorPageAgent::didScroll): (WebCore): (WebCore::InspectorPageAgent::didRecalculateStyle): * inspector/InspectorPageAgent.h: TBR=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135284

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -11 lines)			Patch
M	Source/WebCore/inspector/InspectorInstrumentation.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/WebCore/inspector/InspectorPageAgent.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/WebCore/inspector/InspectorPageAgent.cpp	View	5 chunks	+25 lines, -10 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages