Testing commit

Testing commit
Modified build/whitespace_file.txt
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168922

[vasilii-Google, 2012-11-20 01:57:43]

Hi,

Could you be so kind to conduct a code review for me?

Thanks,
Vasilii

[Nico, 2012-11-20 02:00:39]

For the review description: If there's no bug for a CL, we usually write
`BUG=none` or just `BUG=`, not `BUG=n/a`. If you want, you can go to
new.crbug.com and file "whitespace file is missing a statement about
inflexibility" (or some such) and then reference that bug – but that's optional.

https://codereview.chromium.org/11413076/diff/1/build/whitespace_file.txt
File build/whitespace_file.txt (right):

https://codereview.chromium.org/11413076/diff/1/build/whitespace_file.txt#new...
build/whitespace_file.txt:71: A INFLEXIBLE POSITION SOMETIMES IS A SIGN OF
PARALYSIS
AN

[vasilii-Google, 2012-11-20 02:15:48]

Please be noticed that I modified text according to your comment.

[Nico, 2012-11-20 02:17:07]

On 2012/11/20 02:15:48, vasilii wrote:
> Please be noticed that I modified text according to your comment.

Normally, you'd click the link in the email (from my review), and then rietveld
will show you some UI with "reply" and "done" buttons. For stuff you've just
done and that doesn't need discussion, you'd just hit "done", then 'm' on your
keyboard. Do you want to try that?

[vasilii-Google, 2012-11-20 02:21:24]

Did you mean that?

https://codereview.chromium.org/11413076/diff/1/build/whitespace_file.txt
File build/whitespace_file.txt (right):

https://codereview.chromium.org/11413076/diff/1/build/whitespace_file.txt#new...
build/whitespace_file.txt:71: A INFLEXIBLE POSITION SOMETIMES IS A SIGN OF
PARALYSIS
On 2012/11/20 02:00:39, Nico wrote:
> AN

Done.

[Nico, 2012-11-20 02:25:51]

Ok, one more thing: Somehow you uploaded this in a way that deleted the CC line.
Usually every change has a non-empty CC line. How did you upload this? Where did
the CC line go?

https://codereview.chromium.org/11413076/diff/1/build/whitespace_file.txt
File build/whitespace_file.txt (right):

https://codereview.chromium.org/11413076/diff/1/build/whitespace_file.txt#new...
build/whitespace_file.txt:71: A INFLEXIBLE POSITION SOMETIMES IS A SIGN OF
PARALYSIS
On 2012/11/20 02:21:25, vasilii wrote:
> On 2012/11/20 02:00:39, Nico wrote:
> > AN
> 
> Done.

Yup. If there was further discussion on this point, I'd add it down here too
(for example: "Is this new line really by JENNY HOLZER like line 64 claims?")

[vasilii-Google, 2012-11-20 02:35:40]

On 2012/11/20 02:25:51, Nico wrote:
> Ok, one more thing: Somehow you uploaded this in a way that deleted the CC
line.
> Usually every change has a non-empty CC line. How did you upload this? Where
did
> the CC line go?
> 
> https://codereview.chromium.org/11413076/diff/1/build/whitespace_file.txt
> File build/whitespace_file.txt (right):
> 
>
https://codereview.chromium.org/11413076/diff/1/build/whitespace_file.txt#new...
> build/whitespace_file.txt:71: A INFLEXIBLE POSITION SOMETIMES IS A SIGN OF
> PARALYSIS
> On 2012/11/20 02:21:25, vasilii wrote:
> > On 2012/11/20 02:00:39, Nico wrote:
> > > AN
> > 
> > Done.
> 
> Yup. If there was further discussion on this point, I'd add it down here too
> (for example: "Is this new line really by JENNY HOLZER like line 64 claims?")

CC line from where? Description?
Quote is not by JENNY HOLZER.

[Nico, 2012-11-20 02:37:18]

If you hit 'm', there's a CC: entry. It's empty on this cl. It's not on any
other random review on https://codereview.chromium.org/all

[Nico, 2012-11-20 02:37:31]

(Also, all other CLs have that entry on the left side too)

[vasilii-Google, 2012-11-20 02:40:01]

Added CC.

[vasilii-Google, 2012-11-20 02:49:57]

I modified the text to separate the new quote.

[Nico, 2012-11-20 05:04:23]

On 2012/11/20 02:40:01, vasilii wrote:
> Added CC.

Do you know how it got removed? Normally the CC should appear without you having
to do anything. Maybe you want to run `git cl issue 0` to disassociate your
current branch from this issue and then run `git cl upload` again to get a new
issue with the default cc list and so on.

[vasilii-Google, 2012-11-20 18:03:13]

On 2012/11/20 05:04:23, Nico wrote:
> On 2012/11/20 02:40:01, vasilii wrote:
> > Added CC.
> 
> Do you know how it got removed? Normally the CC should appear without you
having
> to do anything. Maybe you want to run `git cl issue 0` to disassociate your
> current branch from this issue and then run `git cl upload` again to get a new
> issue with the default cc list and so on.

I removed it manually. Then I restored it.

[Nico, 2012-11-20 18:11:55]

On 2012/11/20 18:03:13, vasilii wrote:
> On 2012/11/20 05:04:23, Nico wrote:
> > On 2012/11/20 02:40:01, vasilii wrote:
> > > Added CC.
> > 
> > Do you know how it got removed? Normally the CC should appear without you
> having
> > to do anything. Maybe you want to run `git cl issue 0` to disassociate your
> > current branch from this issue and then run `git cl upload` again to get a
new
> > issue with the default cc list and so on.
> 
> I removed it manually. Then I restored it.

Ah, ok. LGTM in that case. Don't remove it in the future :-)

(If you click through to rietveld, you'll see that this comment is now
highlighted as green -- rietveld just looks for "lgtm" (case-insensitively) and
counts that as a positive review. If you say "this does not lgtm", rietveld
would also think that's a positive review, so only use the string "lgtm" in
replies in which you're approving a change.)

You can now click on the "commit" checkbox on rietveld. That will run the patch
through trybots again and if they all come back green, it'll submit the change.

[Nico, 2012-11-20 18:12:28]

Apparently rietveld now does some simple checking for "not" and turned my
comment red instead :-D

LGTM

[commit-bot: I haz the power, 2012-11-20 18:23:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vasilii@google.com/11413076/4

[vasilii-Google, 2012-11-20 18:24:41]

On 2012/11/20 18:12:28, Nico wrote:
> Apparently rietveld now does some simple checking for "not" and turned my
> comment red instead :-D
> 
> LGTM

I'm committing the change set.

[commit-bot: I haz the power, 2012-11-20 19:28:26]

Retried try job too often for step(s) content_browsertests

[commit-bot: I haz the power, 2012-11-20 19:47:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vasilii@google.com/11413076/4

[commit-bot: I haz the power, 2012-11-21 00:06:59]

Change committed as 168922