Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 11413065: Adding first WebRTC browser test to content_browsertests (Closed)

Created:
8 years, 1 month ago by phoglund_chromium
Modified:
8 years ago
Reviewers:
perkj_chrome, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Adding first WebRTC browser test. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170498

Patch Set 1 #

Total comments: 4

Patch Set 2 : Moved to content/browser, got rid of DEPS override #

Total comments: 2

Patch Set 3 : Review updates #

Patch Set 4 : Disabled audio-only test for now: need proper fake device support first. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
A content/browser/webrtc_getusermedia_browsertest.cc View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/media/getusermedia_and_stop.html View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
phoglund_chromium
Per: Main review. John: Optional review. We talked briefly about this when I was in ...
8 years, 1 month ago (2012-11-19 17:49:37 UTC) #1
jam
https://codereview.chromium.org/11413065/diff/1/content/renderer/DEPS File content/renderer/DEPS (right): https://codereview.chromium.org/11413065/diff/1/content/renderer/DEPS#newcode5 content/renderer/DEPS:5: "+content/public/browser/web_contents.h", # For tests. nit: i realize there are ...
8 years, 1 month ago (2012-11-19 19:14:51 UTC) #2
phoglund_chromium
https://codereview.chromium.org/11413065/diff/1/content/renderer/DEPS File content/renderer/DEPS (right): https://codereview.chromium.org/11413065/diff/1/content/renderer/DEPS#newcode5 content/renderer/DEPS:5: "+content/public/browser/web_contents.h", # For tests. On 2012/11/19 19:14:51, John Abd-El-Malek ...
8 years, 1 month ago (2012-11-20 09:02:03 UTC) #3
perkj_chrome
nice and simple http://codereview.chromium.org/11413065/diff/2002/content/browser/webrtc_getusermedia_browsertest.cc File content/browser/webrtc_getusermedia_browsertest.cc (right): http://codereview.chromium.org/11413065/diff/2002/content/browser/webrtc_getusermedia_browsertest.cc#newcode5 content/browser/webrtc_getusermedia_browsertest.cc:5: #include "base/utf_string_conversions.h" Add comment what this ...
8 years, 1 month ago (2012-11-20 14:20:16 UTC) #4
phoglund_chromium
8 years, 1 month ago (2012-11-22 10:20:54 UTC) #5
phoglund_chromium
On 2012/11/22 10:20:54, phoglund wrote: Sorry about the delay by the way: I made updates ...
8 years, 1 month ago (2012-11-22 10:21:24 UTC) #6
phoglund_chromium
On 2012/11/22 10:21:24, phoglund wrote: > On 2012/11/22 10:20:54, phoglund wrote: > > Sorry about ...
8 years ago (2012-11-27 15:06:33 UTC) #7
jam
lgtm
8 years ago (2012-11-27 18:12:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/11413065/8001
8 years ago (2012-11-28 08:49:04 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) content_browsertests
8 years ago (2012-11-28 09:48:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/11413065/13001
8 years ago (2012-11-30 16:54:00 UTC) #11
commit-bot: I haz the power
8 years ago (2012-11-30 18:53:19 UTC) #12
Message was sent while issue was closed.
Change committed as 170498

Powered by Google App Engine
This is Rietveld 408576698