Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6116)

Unified Diff: chrome/browser/profiles/profile_destroyer_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_destroyer_unittest.cc
diff --git a/chrome/browser/profiles/profile_destroyer_unittest.cc b/chrome/browser/profiles/profile_destroyer_unittest.cc
index c9777a4893a0e0ed78e36e746fca9b3b5378d2f1..c1c929785cb2b8e1d3c526521d72e3b10dd8a113 100644
--- a/chrome/browser/profiles/profile_destroyer_unittest.cc
+++ b/chrome/browser/profiles/profile_destroyer_unittest.cc
@@ -86,12 +86,12 @@ TEST_F(ProfileDestroyerTest, DelayProfileDestruction) {
render_process_host1.release()->Cleanup();
// And asynchronicity kicked in properly.
- MessageLoop::current()->RunAllPending();
+ MessageLoop::current()->RunUntilIdle();
EXPECT_FALSE(off_the_record_profile_->destroyed_otr_profile_);
// I meant, ALL the render process hosts... :-)
render_process_host2.release()->Cleanup();
- MessageLoop::current()->RunAllPending();
+ MessageLoop::current()->RunUntilIdle();
EXPECT_TRUE(off_the_record_profile_->destroyed_otr_profile_);
}
@@ -118,7 +118,7 @@ TEST_F(ProfileDestroyerTest, DelayOriginalProfileDestruction) {
EXPECT_FALSE(original_profile->destroyed_otr_profile_);
render_process_host1.release()->Cleanup();
- MessageLoop::current()->RunAllPending();
+ MessageLoop::current()->RunUntilIdle();
EXPECT_EQ(NULL, TestingOriginalDestructionProfile::living_instance_);
// And the same protection should apply to the main profile.
@@ -133,6 +133,6 @@ TEST_F(ProfileDestroyerTest, DelayOriginalProfileDestruction) {
ProfileDestroyer::DestroyProfileWhenAppropriate(main_profile);
EXPECT_EQ(main_profile, TestingOriginalDestructionProfile::living_instance_);
render_process_host2.release()->Cleanup();
- MessageLoop::current()->RunAllPending();
+ MessageLoop::current()->RunUntilIdle();
EXPECT_EQ(NULL, TestingOriginalDestructionProfile::living_instance_);
}
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud_unittest.cc ('k') | chrome/browser/profiles/profile_info_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698