Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4700)

Unified Diff: chrome/browser/net/ssl_config_service_manager_pref_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
diff --git a/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc b/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
index b4d7080c459903ee86c3e462be90cbe0deedac7b..ef9b0be1f0a8a2c33182f032e39fb56b3bea72b0 100644
--- a/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
+++ b/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
@@ -47,7 +47,7 @@ class SSLConfigServiceManagerPrefTest : public testing::Test {
bool IsChannelIdEnabled(SSLConfigService* config_service) {
// Pump the message loop to notify the SSLConfigServiceManagerPref that the
// preferences changed.
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
SSLConfig config;
config_service->GetSSLConfig(&config);
return config.channel_id_enabled;
@@ -79,7 +79,7 @@ TEST_F(SSLConfigServiceManagerPrefTest, ChannelIDWithoutUserPrefs) {
Value::CreateBooleanValue(true));
// Pump the message loop to notify the SSLConfigServiceManagerPref that the
// preferences changed.
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
config_service->GetSSLConfig(&config);
EXPECT_TRUE(config.channel_id_enabled);
}
@@ -170,7 +170,7 @@ TEST_F(SSLConfigServiceManagerPrefTest, GoodDisabledCipherSuites) {
// Pump the message loop to notify the SSLConfigServiceManagerPref that the
// preferences changed.
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
SSLConfig config;
config_service->GetSSLConfig(&config);
@@ -207,7 +207,7 @@ TEST_F(SSLConfigServiceManagerPrefTest, BadDisabledCipherSuites) {
// Pump the message loop to notify the SSLConfigServiceManagerPref that the
// preferences changed.
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
SSLConfig config;
config_service->GetSSLConfig(&config);

Powered by Google App Engine
This is Rietveld 408576698