chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_message_process_host_unittest_posix.cc ('k') | chrome/browser/extensions/event_router_forwarder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index e23f2db2ca746ffb328d4365db0d622fd9893a3a..027cf046e6ae549a52ee65e1bd4e4fc8ae6282cd 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -608,7 +608,7 @@ TEST_F(ExtensionWebRequestTest, AccessRequestBodyData) {

FireURLRequestWithData(kMethodPost, kMultipart, form_1, form_2);

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

// We inspect the result in the message list of |ipc_sender_| later.

ExtensionWebRequestEventRouter::GetInstance()->RemoveEventListener(

@@ -650,7 +650,7 @@ TEST_F(ExtensionWebRequestTest, AccessRequestBodyData) {

// Now send a PUT request with the same body as above.

FireURLRequestWithData(kMethodPut, NULL /*no header*/, plain_1, plain_2);

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

// Clean-up.

ExtensionWebRequestEventRouter::GetInstance()->RemoveEventListener(