chrome/browser/download/chrome_download_manager_delegate_unittest.cc - Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/chrome_download_manager_delegate_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc ('k') | chrome/browser/download/download_path_reservation_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/chrome_download_manager_delegate_unittest.cc

diff --git a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc

index a3b6506dae8c72abec2ef8f444a6d469549ffe62..fc32f552953976702c674087a068506466265303 100644

--- a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc

+++ b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc

@@ -312,7 +312,7 @@ void ChromeDownloadManagerDelegateTest::SetUp() {

}

void ChromeDownloadManagerDelegateTest::TearDown() {

- message_loop_.RunAllPending();

+ message_loop_.RunUntilIdle();

delegate_->Shutdown();

ChromeRenderViewHostTestHarness::TearDown();

}

@@ -447,7 +447,7 @@ void ChromeDownloadManagerDelegateTest::RunTestCaseWithDownloadItem(

item,

base::Bind(&ChromeDownloadManagerDelegateTest::DownloadTargetVerifier,

factory.GetWeakPtr(), base::Unretained(&test_case))));

- message_loop_.RunAllPending();

+ message_loop_.RunUntilIdle();

VerifyAndClearExpectations();

}