Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
diff --git a/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc b/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
index 5730262976df041a2f03a97c07f804f3f3a0ac5a..e102e0462de6f82b4f9b6da8bdf15fecd32a9e06 100644
--- a/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
+++ b/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
@@ -247,12 +247,12 @@ class ProxyConfigServiceImplTestBase : public TESTBASE {
// SetChromeProxyConfigService triggers update of initial prefs proxy
// config by tracker to chrome proxy config service, so flush all pending
// tasks so that tests start fresh.
- loop_.RunAllPending();
+ loop_.RunUntilIdle();
}
virtual void TearDown() {
config_service_impl_->DetachFromPrefService();
- loop_.RunAllPending();
+ loop_.RunUntilIdle();
config_service_impl_.reset();
proxy_config_service_.reset();
DBusThreadManager::Shutdown();
@@ -315,7 +315,7 @@ class ProxyConfigServiceImplTestBase : public TESTBASE {
net::ProxyConfig* config) {
*config = net::ProxyConfig();
// Let message loop process all messages.
- loop_.RunAllPending();
+ loop_.RunUntilIdle();
// Calls ChromeProIOGetProxyConfig (which is called from
// ProxyConfigService::GetLatestProxyConfig), running on faked IO thread.
return proxy_config_service_->GetLatestProxyConfig(config);

Powered by Google App Engine
This is Rietveld 408576698