Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8600)

Unified Diff: chrome/browser/chromeos/login/online_attempt_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/online_attempt_unittest.cc
diff --git a/chrome/browser/chromeos/login/online_attempt_unittest.cc b/chrome/browser/chromeos/login/online_attempt_unittest.cc
index e6a8c0106af8328605ce33773666b46e03dba8ad..fc50f347af1f4fb43c6c32529a3e95717155430d 100644
--- a/chrome/browser/chromeos/login/online_attempt_unittest.cc
+++ b/chrome/browser/chromeos/login/online_attempt_unittest.cc
@@ -58,7 +58,7 @@ class OnlineAttemptTest : public testing::Test {
attempt_->weak_factory_.GetWeakPtr(),
error));
// Force UI thread to finish tasks so I can verify |state_|.
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
EXPECT_TRUE(error == state_.online_outcome().error());
}
@@ -75,7 +75,7 @@ class OnlineAttemptTest : public testing::Test {
}
static void RunThreadTest() {
- MessageLoop::current()->RunAllPending();
+ MessageLoop::current()->RunUntilIdle();
}
MessageLoop message_loop_;
@@ -99,7 +99,7 @@ TEST_F(OnlineAttemptTest, LoginSuccess) {
attempt_->weak_factory_.GetWeakPtr(),
GaiaAuthConsumer::ClientLoginResult()));
// Force UI thread to finish tasks so I can verify |state_|.
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
TEST_F(OnlineAttemptTest, LoginCancelRetry) {
@@ -249,7 +249,7 @@ TEST_F(OnlineAttemptTest, TwoFactorSuccess) {
error));
// Force UI thread to finish tasks so I can verify |state_|.
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
EXPECT_TRUE(GoogleServiceAuthError::None() ==
state_.online_outcome().error());
}

Powered by Google App Engine
This is Rietveld 408576698