Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2441)

Unified Diff: chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm
diff --git a/chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm b/chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm
index 7adcc1cb95cfb8a8506f29133f48523985a3a46b..d64661f4e4360e20a13e5ba0c7cea9cfee1c5999 100644
--- a/chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm
+++ b/chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm
@@ -98,7 +98,7 @@ TEST_F(RemovableDeviceNotificationsMacTest, AddRemove) {
mount_point_.value()));
notifications_->UpdateDisk(
disk_info_, RemovableDeviceNotificationsMac::UPDATE_DEVICE_ADDED);
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
{
@@ -106,7 +106,7 @@ TEST_F(RemovableDeviceNotificationsMacTest, AddRemove) {
OnRemovableStorageDetached(device_id_));
notifications_->UpdateDisk(
disk_info_, RemovableDeviceNotificationsMac::UPDATE_DEVICE_REMOVED);
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
}
@@ -118,7 +118,7 @@ TEST_F(RemovableDeviceNotificationsMacTest, UpdateVolumeName) {
mount_point_.value()));
notifications_->UpdateDisk(
disk_info_, RemovableDeviceNotificationsMac::UPDATE_DEVICE_ADDED);
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
{
@@ -133,7 +133,7 @@ TEST_F(RemovableDeviceNotificationsMacTest, UpdateVolumeName) {
mount_point_.value()));
notifications_->UpdateDisk(
info2, RemovableDeviceNotificationsMac::UPDATE_DEVICE_CHANGED);
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
}
@@ -155,7 +155,7 @@ TEST_F(RemovableDeviceNotificationsMacTest, DCIM) {
mount_point.value()));
notifications_->UpdateDisk(
info, RemovableDeviceNotificationsMac::UPDATE_DEVICE_ADDED);
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
}
@@ -167,7 +167,7 @@ TEST_F(RemovableDeviceNotificationsMacTest, GetDeviceInfo) {
mount_point_.value()));
notifications_->UpdateDisk(
disk_info_, RemovableDeviceNotificationsMac::UPDATE_DEVICE_ADDED);
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
base::SystemMonitor::RemovableStorageInfo info;
@@ -191,7 +191,7 @@ TEST_F(RemovableDeviceNotificationsMacTest, DMG) {
unique_id_, "Disk Image", display_name_, mount_point_);
notifications_->UpdateDisk(
info, RemovableDeviceNotificationsMac::UPDATE_DEVICE_ADDED);
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698