Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2273)

Unified Diff: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
index 2f9f00f64828444bdc2b97c678b03fa0e971a013..83203f89526a5fd3b3a0868bcf0baf7ea12cb8d7 100644
--- a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
@@ -293,7 +293,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
// This noticeably speeds up the unit tests that request it.
if (save == DONT_SAVE_TO_STORAGE)
model_->ClearStore();
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
int GetSyncBookmarkCount() {
@@ -408,7 +408,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
EXPECT_EQ(GetSyncBookmarkCount(),
syncer_merge_result_.num_items_after_association());
- MessageLoop::current()->RunAllPending();
+ MessageLoop::current()->RunUntilIdle();
// Set up change processor.
change_processor_.reset(
@@ -423,7 +423,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
EXPECT_FALSE(error.IsSet());
model_associator_.reset();
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
// TODO(akalin): Actually close the database and flush it to disk
// (and make StartSync reload from disk). This would require
@@ -433,7 +433,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
void UnloadBookmarkModel() {
profile_.CreateBookmarkModel(false /* delete_bookmarks */);
model_ = NULL;
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
bool InitSyncNodeFromChromeNode(const BookmarkNode* bnode,

Powered by Google App Engine
This is Rietveld 408576698