Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2223)

Unified Diff: chrome/browser/sync/glue/data_type_manager_impl_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
diff --git a/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc b/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
index a5aac508a3b9c4cba20d424366bd06aa5a091082..8dace73c9ffd313661a311ab573539fbce506430 100644
--- a/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
+++ b/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
@@ -523,7 +523,7 @@ TEST_F(SyncDataTypeManagerImplTest, ConfigureWhileOneInFlight) {
// Pump the loop to run the posted DTMI::ConfigureImpl() task from
// DTMI::ProcessReconfigure() (triggered by FinishStart()).
- ui_loop_.RunAllPending();
+ ui_loop_.RunUntilIdle();
EXPECT_EQ(DataTypeManager::DOWNLOAD_PENDING, dtm.state());
// Step 5.
@@ -683,7 +683,7 @@ TEST_F(SyncDataTypeManagerImplTest, ConfigureWhileDownloadPending) {
// Pump the loop to run the posted DTMI::ConfigureImpl() task from
// DTMI::ProcessReconfigure() (triggered by step 3).
- ui_loop_.RunAllPending();
+ ui_loop_.RunUntilIdle();
EXPECT_EQ(DataTypeManager::DOWNLOAD_PENDING, dtm.state());
// Step 4.
@@ -739,7 +739,7 @@ TEST_F(SyncDataTypeManagerImplTest, ConfigureWhileDownloadPendingWithFailure) {
// Pump the loop to run the posted DTMI::ConfigureImpl() task from
// DTMI::ProcessReconfigure() (triggered by step 3).
- ui_loop_.RunAllPending();
+ ui_loop_.RunUntilIdle();
EXPECT_EQ(DataTypeManager::DOWNLOAD_PENDING, dtm.state());
// Step 4.
@@ -849,7 +849,7 @@ TEST_F(SyncDataTypeManagerImplTest, ConfigureDuringPurge) {
SetConfigureDoneExpectation(DataTypeManager::OK);
// Pump the loop to run the posted DTMI::ConfigureImpl() task from
// DTMI::ProcessReconfigure().
- ui_loop_.RunAllPending();
+ ui_loop_.RunUntilIdle();
EXPECT_EQ(DataTypeManager::DOWNLOAD_PENDING, dtm.state());
// Now invoke the callback for the second configure request.

Powered by Google App Engine
This is Rietveld 408576698