chrome/browser: Update calls from RunAllPending() to RunUntilIdle().

chrome/browser/notifications/desktop_notifications_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/desktop_notifications_unittest.h"
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/notifications/fake_balloon_view.h"
 #include "chrome/browser/prefs/browser_prefs.h"
@@ skipping 121 matching lines @@
   return params;
 }
 
 TEST_F(DesktopNotificationsTest, TestShow) {
   content::ShowDesktopNotificationHostMsgParams params =
       StandardTestNotification();
   params.notification_id = 1;
 
   EXPECT_TRUE(service_->ShowDesktopNotification(
       params, 0, 0, DesktopNotificationService::PageNotification));
-  MessageLoopForUI::current()->RunAllPending();
+  MessageLoopForUI::current()->RunUntilIdle();
   EXPECT_EQ(1, balloon_collection_->count());
 
   content::ShowDesktopNotificationHostMsgParams params2;
   params2.origin = GURL("http://www.google.com");
   params2.is_html = true;
   params2.contents_url = GURL("http://www.google.com/notification.html");
   params2.notification_id = 2;
 
   EXPECT_TRUE(service_->ShowDesktopNotification(
       params2, 0, 0, DesktopNotificationService::PageNotification));
-  MessageLoopForUI::current()->RunAllPending();
+  MessageLoopForUI::current()->RunUntilIdle();
   EXPECT_EQ(2, balloon_collection_->count());
 
   EXPECT_EQ("notification displayed\n"
             "notification displayed\n",
             log_output_);
 }
 
 TEST_F(DesktopNotificationsTest, TestClose) {
   content::ShowDesktopNotificationHostMsgParams params =
       StandardTestNotification();
   params.notification_id = 1;
 
   // Request a notification; should open a balloon.
   EXPECT_TRUE(service_->ShowDesktopNotification(
       params, 0, 0, DesktopNotificationService::PageNotification));
-  MessageLoopForUI::current()->RunAllPending();
+  MessageLoopForUI::current()->RunUntilIdle();
   EXPECT_EQ(1, balloon_collection_->count());
 
   // Close all the open balloons.
   while (balloon_collection_->count() > 0) {
     (*(balloon_collection_->GetActiveBalloons().begin()))->OnClose(true);
   }
 
   EXPECT_EQ("notification displayed\n"
             "notification closed by user\n",
             log_output_);
 }
 
 TEST_F(DesktopNotificationsTest, TestCancel) {
   int process_id = 0;
   int route_id = 0;
   int notification_id = 1;
 
   content::ShowDesktopNotificationHostMsgParams params =
       StandardTestNotification();
   params.notification_id = notification_id;
 
   // Request a notification; should open a balloon.
   EXPECT_TRUE(service_->ShowDesktopNotification(
       params, process_id, route_id,
       DesktopNotificationService::PageNotification));
-  MessageLoopForUI::current()->RunAllPending();
+  MessageLoopForUI::current()->RunUntilIdle();
   EXPECT_EQ(1, balloon_collection_->count());
 
   // Cancel the same notification
   service_->CancelDesktopNotification(process_id,
                                       route_id,
                                       notification_id);
-  MessageLoopForUI::current()->RunAllPending();
+  MessageLoopForUI::current()->RunUntilIdle();
   // Verify that the balloon collection is now empty.
   EXPECT_EQ(0, balloon_collection_->count());
 
   EXPECT_EQ("notification displayed\n"
             "notification closed by script\n",
             log_output_);
 }
 
 #if defined(OS_WIN) || defined(TOOLKIT_VIEWS)
 TEST_F(DesktopNotificationsTest, TestPositioning) {
@@ skipping 67 matching lines @@
   // Request lots of identical notifications.
   content::ShowDesktopNotificationHostMsgParams params =
       StandardTestNotification();
   const int kLotsOfToasts = 20;
   for (int id = 1; id <= kLotsOfToasts; ++id) {
     params.notification_id = id;
     EXPECT_TRUE(service_->ShowDesktopNotification(
         params, process_id, route_id,
         DesktopNotificationService::PageNotification));
   }
-  MessageLoopForUI::current()->RunAllPending();
+  MessageLoopForUI::current()->RunUntilIdle();
 
   // Build up an expected log of what should be happening.
   std::string expected_log;
   for (int i = 0; i < balloon_collection_->max_balloon_count(); ++i) {
     expected_log.append("notification displayed\n");
   }
 
   // The max number that our balloon collection can hold should be
   // shown.
   EXPECT_EQ(balloon_collection_->max_balloon_count(),
             balloon_collection_->count());
   EXPECT_EQ(expected_log, log_output_);
 
   // Cancel the notifications from the start; the balloon space should
   // remain full.
   {
     int id;
     for (id = 1;
          id <= kLotsOfToasts - balloon_collection_->max_balloon_count();
          ++id) {
       service_->CancelDesktopNotification(process_id, route_id, id);
-      MessageLoopForUI::current()->RunAllPending();
+      MessageLoopForUI::current()->RunUntilIdle();
       expected_log.append("notification closed by script\n");
       expected_log.append("notification displayed\n");
       EXPECT_EQ(balloon_collection_->max_balloon_count(),
                 balloon_collection_->count());
       EXPECT_EQ(expected_log, log_output_);
     }
 
     // Now cancel the rest.  It should empty the balloon space.
     for (; id <= kLotsOfToasts; ++id) {
       service_->CancelDesktopNotification(process_id, route_id, id);
       expected_log.append("notification closed by script\n");
-      MessageLoopForUI::current()->RunAllPending();
+      MessageLoopForUI::current()->RunUntilIdle();
       EXPECT_EQ(expected_log, log_output_);
     }
   }
 
   // Verify that the balloon collection is now empty.
   EXPECT_EQ(0, balloon_collection_->count());
 }
 
 TEST_F(DesktopNotificationsTest, TestEarlyDestruction) {
   // Create some toasts and then prematurely delete the notification service,
@@ skipping 12 matching lines @@
   // Create a test script with some HTML; assert that it doesn't get into the
   // data:// URL that's produced for the balloon.
   content::ShowDesktopNotificationHostMsgParams params =
       StandardTestNotification();
   params.title = ASCIIToUTF16("<script>window.alert('uh oh');</script>");
   params.body = ASCIIToUTF16("<i>this text is in italics</i>");
   params.notification_id = 1;
   EXPECT_TRUE(service_->ShowDesktopNotification(
       params, 0, 0, DesktopNotificationService::PageNotification));
 
-  MessageLoopForUI::current()->RunAllPending();
+  MessageLoopForUI::current()->RunUntilIdle();
   EXPECT_EQ(1, balloon_collection_->count());
   Balloon* balloon = (*balloon_collection_->balloons().begin());
   GURL data_url = balloon->notification().content_url();
   EXPECT_EQ(std::string::npos, data_url.spec().find("<script>"));
   EXPECT_EQ(std::string::npos, data_url.spec().find("<i>"));
   // URL-encoded versions of tags should also not be found.
   EXPECT_EQ(std::string::npos, data_url.spec().find("%3cscript%3e"));
   EXPECT_EQ(std::string::npos, data_url.spec().find("%3ci%3e"));
 }
 
@@ skipping 98 matching lines @@
   }
 
   // Now change the position to upper left.  Confirm that the X value for the
   // balloons gets smaller.
   local_state_.SetInteger(prefs::kDesktopNotificationPosition,
                           BalloonCollection::UPPER_LEFT);
 
   int current_x = (*balloons.begin())->GetPosition().x();
   EXPECT_LT(current_x, last_x);
 }