chrome/browser: Update calls from RunAllPending() to RunUntilIdle().

chrome/browser/download/download_path_reservation_tracker_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop.h"
 #include "base/observer_list.h"
@@ skipping 89 matching lines @@
     : ui_thread_(BrowserThread::UI, &message_loop_),
       file_thread_(BrowserThread::FILE, &message_loop_) {
 }
 
 void DownloadPathReservationTrackerTest::SetUp() {
   ASSERT_TRUE(test_download_dir_.CreateUniqueTempDir());
   set_default_download_path(test_download_dir_.path());
 }
 
 void DownloadPathReservationTrackerTest::TearDown() {
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 }
 
 FakeDownloadItem* DownloadPathReservationTrackerTest::CreateDownloadItem(
     int32 id) {
   FakeDownloadItem* item = new ::testing::StrictMock<FakeDownloadItem>;
   DownloadId download_id(reinterpret_cast<void*>(this), id);
   EXPECT_CALL(*item, GetGlobalId())
       .WillRepeatedly(Return(download_id));
   EXPECT_CALL(*item, GetTargetFilePath())
       .WillRepeatedly(ReturnRefOfCopy(FilePath()));
@@ skipping 18 matching lines @@
   // Weak pointer factory to prevent the callback from running after this
   // function has returned.
   base::WeakPtrFactory<DownloadPathReservationTrackerTest> weak_ptr_factory(
       this);
   bool did_run_callback = false;
   DownloadPathReservationTracker::GetReservedPath(
       download_item, target_path, default_download_path(), uniquify_path,
       base::Bind(&DownloadPathReservationTrackerTest::TestReservedPathCallback,
                  weak_ptr_factory.GetWeakPtr(), return_path, return_verified,
                  &did_run_callback));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
   EXPECT_TRUE(did_run_callback);
 }
 
 void DownloadPathReservationTrackerTest::TestReservedPathCallback(
     FilePath* return_path, bool* return_verified, bool* did_run_callback,
     const FilePath& path, bool verified) {
   *did_run_callback = true;
   *return_path = path;
   *return_verified = verified;
 }
 
 }  // namespace
 
 // A basic reservation is acquired and committed.
 TEST_F(DownloadPathReservationTrackerTest, BasicReservation) {
   scoped_ptr<FakeDownloadItem> item(CreateDownloadItem(1));
   FilePath path(GetPathInDownloadsDirectory(FILE_PATH_LITERAL("foo.txt")));
   ASSERT_FALSE(IsPathInUse(path));
 
   FilePath reserved_path;
   bool verified = false;
   CallGetReservedPath(*item, path, false, &reserved_path, &verified);
   EXPECT_TRUE(IsPathInUse(path));
   EXPECT_TRUE(verified);
   EXPECT_EQ(path.value(), reserved_path.value());
 
   // Destroying the item should release the reservation.
   item.reset();
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
   EXPECT_FALSE(IsPathInUse(path));
 }
 
 // A download that is interrupted should lose its reservation.
 TEST_F(DownloadPathReservationTrackerTest, InterruptedDownload) {
   scoped_ptr<FakeDownloadItem> item(CreateDownloadItem(1));
   FilePath path(GetPathInDownloadsDirectory(FILE_PATH_LITERAL("foo.txt")));
   ASSERT_FALSE(IsPathInUse(path));
 
   FilePath reserved_path;
   bool verified = false;
   CallGetReservedPath(*item, path, false, &reserved_path, &verified);
   EXPECT_TRUE(IsPathInUse(path));
   EXPECT_TRUE(verified);
   EXPECT_EQ(path.value(), reserved_path.value());
 
   // Once the download is interrupted, the path should become available again.
   item->SetState(DownloadItem::INTERRUPTED);
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
   EXPECT_FALSE(IsPathInUse(path));
 }
 
 // A completed download should also lose its reservation.
 TEST_F(DownloadPathReservationTrackerTest, CompleteDownload) {
   scoped_ptr<FakeDownloadItem> item(CreateDownloadItem(1));
   FilePath path(GetPathInDownloadsDirectory(FILE_PATH_LITERAL("foo.txt")));
   ASSERT_FALSE(IsPathInUse(path));
 
   FilePath reserved_path;
   bool verified = false;
   CallGetReservedPath(*item, path, false, &reserved_path, &verified);
   EXPECT_TRUE(IsPathInUse(path));
   EXPECT_TRUE(verified);
   EXPECT_EQ(path.value(), reserved_path.value());
 
   // Once the download completes, the path should become available again. For a
   // real download, at this point only the path reservation will be released.
   // The path wouldn't be available since it is occupied on disk by the
   // completed download.
   item->SetState(DownloadItem::COMPLETE);
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
   EXPECT_FALSE(IsPathInUse(path));
 }
 
 // If there are files on the file system, a unique reservation should uniquify
 // around it.
 TEST_F(DownloadPathReservationTrackerTest, ConflictingFiles) {
   scoped_ptr<FakeDownloadItem> item(CreateDownloadItem(1));
   FilePath path(GetPathInDownloadsDirectory(FILE_PATH_LITERAL("foo.txt")));
   FilePath path1(GetPathInDownloadsDirectory(FILE_PATH_LITERAL("foo (1).txt")));
   // Create a file at |path|, and a .crdownload file at |path1|.
   ASSERT_EQ(0, file_util::WriteFile(path, "", 0));
   ASSERT_EQ(0, file_util::WriteFile(download_util::GetCrDownloadPath(path1),
                                     "", 0));
   ASSERT_TRUE(IsPathInUse(path));
 
   FilePath reserved_path;
   bool verified = false;
   CallGetReservedPath(*item, path, true, &reserved_path, &verified);
   EXPECT_TRUE(IsPathInUse(path));
   EXPECT_TRUE(IsPathInUse(reserved_path));
   EXPECT_TRUE(verified);
   // The path should be uniquified, skipping over foo.txt but not over
   // "foo (1).txt.crdownload"
   EXPECT_EQ(
       GetPathInDownloadsDirectory(FILE_PATH_LITERAL("foo (1).txt")).value(),
       reserved_path.value());
 
   item.reset();
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
   EXPECT_TRUE(IsPathInUse(path));
   EXPECT_FALSE(IsPathInUse(reserved_path));
 }
 
 // Multiple reservations for the same path should uniquify around each other.
 TEST_F(DownloadPathReservationTrackerTest, ConflictingReservations) {
   scoped_ptr<FakeDownloadItem> item1(CreateDownloadItem(1));
   FilePath path(GetPathInDownloadsDirectory(FILE_PATH_LITERAL("foo.txt")));
   FilePath uniquified_path(
       GetPathInDownloadsDirectory(FILE_PATH_LITERAL("foo (1).txt")));
@@ skipping 10 matching lines @@
   {
     // Requesting a reservation for the same path with uniquification results in
     // a uniquified path.
     scoped_ptr<FakeDownloadItem> item2(CreateDownloadItem(2));
     FilePath reserved_path2;
     CallGetReservedPath(*item2, path, true, &reserved_path2, &verified);
     EXPECT_TRUE(IsPathInUse(path));
     EXPECT_TRUE(IsPathInUse(uniquified_path));
     EXPECT_EQ(uniquified_path.value(), reserved_path2.value());
   }
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
   EXPECT_TRUE(IsPathInUse(path));
   EXPECT_FALSE(IsPathInUse(uniquified_path));
 
   {
     // Since the previous download item was removed, requesting a reservation
     // for the same path should result in the same uniquified path.
     scoped_ptr<FakeDownloadItem> item2(CreateDownloadItem(2));
     FilePath reserved_path2;
     CallGetReservedPath(*item2, path, true, &reserved_path2, &verified);
     EXPECT_TRUE(IsPathInUse(path));
     EXPECT_TRUE(IsPathInUse(uniquified_path));
     EXPECT_EQ(uniquified_path.value(), reserved_path2.value());
   }
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Now acquire an overwriting reservation. We should end up with the same
   // non-uniquified path for both reservations.
   scoped_ptr<FakeDownloadItem> item3(CreateDownloadItem(2));
   FilePath reserved_path3;
   CallGetReservedPath(*item3, path, false, &reserved_path3, &verified);
   EXPECT_TRUE(IsPathInUse(path));
   EXPECT_FALSE(IsPathInUse(uniquified_path));
 
   EXPECT_EQ(path.value(), reserved_path1.value());
@@ skipping 94 matching lines @@
   bool verified = false;
   CallGetReservedPath(*item, path, false, &reserved_path, &verified);
   EXPECT_TRUE(IsPathInUse(path));
   EXPECT_TRUE(verified);
   EXPECT_EQ(path.value(), reserved_path.value());
 
   // The target path is initially empty. If an OnDownloadUpdated() is issued in
   // this state, we shouldn't lose the reservation.
   ASSERT_EQ(FilePath::StringType(), item->GetTargetFilePath().value());
   item->UpdateObservers();
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
   EXPECT_TRUE(IsPathInUse(path));
 
   // If the target path changes, we should update the reservation to match.
   FilePath new_target_path(
       GetPathInDownloadsDirectory(FILE_PATH_LITERAL("bar.txt")));
   ASSERT_FALSE(IsPathInUse(new_target_path));
   EXPECT_CALL(*item, GetTargetFilePath())
       .WillRepeatedly(ReturnRef(new_target_path));
   item->UpdateObservers();
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
   EXPECT_FALSE(IsPathInUse(path));
   EXPECT_TRUE(IsPathInUse(new_target_path));
 
   // Destroying the item should release the reservation.
   item.reset();
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
   EXPECT_FALSE(IsPathInUse(new_target_path));
 }