Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 11413011: Add -Wobjc-missing-property-synthesis to comment on symbolic name (Closed)

Created:
8 years, 1 month ago by Miranda Callahan
Modified:
8 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add -Wobjc-missing-property-synthesis to comment on symbolic name CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS for findability. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168223

Patch Set 1 : fixery #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/common.gypi View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Miranda Callahan
Adding comment as was wisely suggested post-committally in a previous CL.
8 years, 1 month ago (2012-11-16 14:09:22 UTC) #1
Mark Mentovai
LGTM!
8 years, 1 month ago (2012-11-16 14:13:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mirandac@chromium.org/11413011/2001
8 years, 1 month ago (2012-11-16 14:20:48 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-16 16:58:49 UTC) #4
Change committed as 168223

Powered by Google App Engine
This is Rietveld 408576698