chrome/android/java_staging/res/layout/dialog_with_titlebar.xml - Issue 1141283003: Upstream oodles of Chrome for Android code into Chromium.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java_staging/res/layout/dialog_with_titlebar.xml

Issue 1141283003: Upstream oodles of Chrome for Android code into Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: final patch? Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java_staging/res/layout/control_container.xml ('k') | chrome/android/java_staging/res/layout/eb_add_edit_folder_activity.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:layout_width="match_parent"

	8 android:layout_height="match_parent" >

	9

	10 <LinearLayout

	11 android:layout_width="match_parent"

	12 android:layout_height="@dimen/toolbar_height_no_shadow"

	13 android:background="@color/default_primary_color" >

	14

	15 <TextView

	16 android:id="@+id/title"

	17 android:layout_width="0dp"

	18 android:layout_height="match_parent"

	19 android:layout_weight="1"

	20 android:fontFamily="sans-serif-medium"

	21 android:gravity="center_vertical"

	22 android:paddingStart="16dp"

	23 android:paddingEnd="16dp"

	24 android:textColor="#333333"

	25 android:textSize="20sp" />

	26

	27 <ImageButton

	28 android:id="@+id/close_button"

	29 style="@style/ToolbarButton"

	30 android:layout_width="52dp"

	31 android:layout_height="match_parent"

	32 android:layout_gravity="top"

	33 android:contentDescription="@string/close"

	34 android:src="@drawable/btn_close" />

	35 </LinearLayout>

	36

	37 <ImageView

	38 android:layout_width="match_parent"

	39 android:layout_height="wrap_content"

	40 android:layout_marginTop="@dimen/toolbar_height_no_shadow"

	41 android:contentDescription="@null"

	42 android:scaleType="fitXY"

	43 android:src="@drawable/toolbar_shadow" />

	44

	45 <!-- Dialog content will be inserted here from Java code -->

	46

	47 </FrameLayout>

OLD	NEW