Issue 11412318: Remove bogus test and add check for OOM in TryCall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412318: Remove bogus test and add check for OOM in TryCall. (Closed)

Created:
8 years ago by Yang

Modified:
8 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove bogus test and add check for OOM in TryCall. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13126

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -14 lines)			Patch
	M	src/execution.cc	View		1 chunk	+3 lines, -0 lines	1 comment	Download
	M	test/cctest/test-debug.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years ago (2012-12-04 09:42:07 UTC) #2

LGTM.

https://codereview.chromium.org/11412318/diff/1/src/execution.cc
File src/execution.cc (right):

https://codereview.chromium.org/11412318/diff/1/src/execution.cc#newcode215
src/execution.cc:215: V8::FatalProcessOutOfMemory(NULL);
Pass some short message to V8::FatalProcessOutOfMemory so that we know where
it's coming from.

Expand Messages | Collapse Messages