Use AutoThread in ChromotingHostContext & NPAPI plugin.

Use AutoThread in ChromotingHostContext & NPAPI plugin.

Callers now create ChromotingHostContext to create a set of threads
for host tasks to run on, and pass the threads' TaskRunners to each
host component explicitly. The ChromotingHostContext can then be
torn down as soon as the caller no longer needs to create new
components using the threads, and the threads themselves will exit
only when the created components no longer require them.

This is a re-re-land of 11094056; the re-land failed due to a rebasing typo, and some over-zealous thread checking in ChromotingHostContext.

BUG=145856
TEST=Chromoting IT2Me & Me2Me hosts start correctly, can be connected to, and shutdown cleanly.  Unit-tests pass.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171358

[Wez, 2012-12-03 20:20:23]

PTAL

[alexeypa (please no reviews), 2012-12-03 20:34:22]

Please make sure that you can actually run and connect to me2me and it2me hosts
with the change.

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
File remoting/host/chromoting_host_context.cc (right):

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
remoting/host/chromoting_host_context.cc:29: video_capture_task_runner_ =
AutoThread::Create(
nit: sort these by the task runners names.

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
remoting/host/chromoting_host_context.cc:45:
DCHECK(ui_task_runner_->BelongsToCurrentThread());
It2MeImpl does not try to delete the context on the UI thread any more. Is this
check still valid?

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
remoting/host/chromoting_host_context.cc:54: if (!context->audio_task_runner_ ||
nit: sort these by the task runners names.

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
File remoting/host/chromoting_host_context.h (right):

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
remoting/host/chromoting_host_context.h:24: virtual ~ChromotingHostContext();
nit: the destructor does not have to be virtual if none of other methods are
virtual.

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
remoting/host/chromoting_host_context.h:72: scoped_refptr<AutoThreadTaskRunner>
video_capture_task_runner_;
nit: since you are touching this code, could you please sort the task runners
(and their accessors) alphabetically?

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/remot...
File remoting/host/remoting_me2me_host.cc (right):

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/remot...
remoting/host/remoting_me2me_host.cc:1094: if (context)
if (!context)

[Wez, 2012-12-03 22:38:45]

Both IT2Me and Me2Me hosts work w/ this patch set. :)

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
File remoting/host/chromoting_host_context.cc (right):

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
remoting/host/chromoting_host_context.cc:29: video_capture_task_runner_ =
AutoThread::Create(
On 2012/12/03 20:34:23, alexeypa wrote:
> nit: sort these by the task runners names.

Done.

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
remoting/host/chromoting_host_context.cc:45:
DCHECK(ui_task_runner_->BelongsToCurrentThread());
On 2012/12/03 20:34:23, alexeypa wrote:
> It2MeImpl does not try to delete the context on the UI thread any more. Is
this
> check still valid?

Done.

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
remoting/host/chromoting_host_context.cc:54: if (!context->audio_task_runner_ ||
On 2012/12/03 20:34:23, alexeypa wrote:
> nit: sort these by the task runners names.

Done.

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
File remoting/host/chromoting_host_context.h (right):

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
remoting/host/chromoting_host_context.h:24: virtual ~ChromotingHostContext();
On 2012/12/03 20:34:23, alexeypa wrote:
> nit: the destructor does not have to be virtual if none of other methods are
> virtual.

Done.

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/chrom...
remoting/host/chromoting_host_context.h:72: scoped_refptr<AutoThreadTaskRunner>
video_capture_task_runner_;
On 2012/12/03 20:34:23, alexeypa wrote:
> nit: since you are touching this code, could you please sort the task runners
> (and their accessors) alphabetically?

Done.

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/remot...
File remoting/host/remoting_me2me_host.cc (right):

https://chromiumcodereview.appspot.com/11412305/diff/1012/remoting/host/remot...
remoting/host/remoting_me2me_host.cc:1094: if (context)
On 2012/12/03 20:34:23, alexeypa wrote:
> if (!context)

Done.

[alexeypa (please no reviews), 2012-12-04 16:30:37]

lgtm

[commit-bot: I haz the power, 2012-12-05 19:11:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11412305/9002

[commit-bot: I haz the power, 2012-12-05 22:39:01]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2012-12-05 23:18:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11412305/9002

[commit-bot: I haz the power, 2012-12-05 23:40:57]

Change committed as 171358