Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 11412302: Roll Clang 167488:168474. (Closed)

Created:
8 years ago by hans
Modified:
8 years ago
Reviewers:
Nico
CC:
chromium-reviews, fischman+watch_chromium.org, glotov+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org, dmikurube+clang_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : CrOS fix #

Patch Set 3 : Disable warning for Skia #

Patch Set 4 : Suppress warning on Mac too #

Patch Set 5 : Simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/chromeos/process_proxy/process_output_watcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
hans
8 years ago (2012-12-03 17:17:09 UTC) #1
Nico
lgtm!
8 years ago (2012-12-03 17:30:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/11412302/7001
8 years ago (2012-12-03 19:20:05 UTC) #3
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) build
8 years ago (2012-12-03 19:51:35 UTC) #4
Nico
On 2012/12/03 19:51:35, I haz the power (commit-bot) wrote: > Retried try job too often ...
8 years ago (2012-12-03 19:52:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/11412302/7001
8 years ago (2012-12-03 19:53:25 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-03 19:55:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/11412302/7001
8 years ago (2012-12-03 20:02:08 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-03 20:05:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/11412302/7001
8 years ago (2012-12-03 21:03:19 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-03 21:10:35 UTC) #11
hans
On 2012/12/03 19:52:26, Nico wrote: > …maybe that bot didn't see the skia roll yet? ...
8 years ago (2012-12-04 09:44:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/11412302/5004
8 years ago (2012-12-04 10:07:47 UTC) #13
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-04 10:27:04 UTC) #14
hans
On 2012/12/04 10:27:04, I haz the power (commit-bot) wrote: > Sorry for I got bad ...
8 years ago (2012-12-04 11:23:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/11412302/10009
8 years ago (2012-12-04 16:32:25 UTC) #16
commit-bot: I haz the power
8 years ago (2012-12-04 19:12:23 UTC) #17
Message was sent while issue was closed.
Change committed as 171017

Powered by Google App Engine
This is Rietveld 408576698