src/heap-inl.h - Issue 11412299: Correctly handle AdjustAmountOfExternalAllocatedMemory(0).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-inl.h

Issue 11412299: Correctly handle AdjustAmountOfExternalAllocatedMemory(0). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-inl.h

diff --git a/src/heap-inl.h b/src/heap-inl.h

index 33bc4f9ad70cc49a19c6e987886f9f323b4a19bd..de47c94a8a4a59f4ad5224ed209c3145fa990563 100644

--- a/src/heap-inl.h

+++ b/src/heap-inl.h

@@ -460,7 +460,7 @@ intptr_t Heap::AdjustAmountOfExternalAllocatedMemory(

intptr_t change_in_bytes) {

ASSERT(HasBeenSetUp());

intptr_t amount = amount_of_external_allocated_memory_ + change_in_bytes;

- if (change_in_bytes >= 0) {

+ if (change_in_bytes > 0) {

// Avoid overflow.

if (amount > amount_of_external_allocated_memory_) {

amount_of_external_allocated_memory_ = amount;

« no previous file with comments | « no previous file | no next file » | no next file with comments »