Fix NaCl IPC proxy startup for ARM.

Fix NaCl IPC proxy startup for ARM.
BUG=116317, 161776
TEST=manual, browser_tests not running on ARM

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170671

[bbudge, 2012-12-01 13:39:07]

Once the build, debug, and platform issues were sorted out, this is all it took
to get the proxy working. Apparently IrtInit() isn't always called by the NaCl
startup code, so we should call it ourselves.

[dmichael (off chromium), 2012-12-01 14:48:47]

lgtm

https://codereview.chromium.org/11412293/diff/1/ppapi/proxy/plugin_main_nacl.cc
File ppapi/proxy/plugin_main_nacl.cc (right):

https://codereview.chromium.org/11412293/diff/1/ppapi/proxy/plugin_main_nacl....
ppapi/proxy/plugin_main_nacl.cc:231: IrtInit();
I assume you verified that it's okay to call it twice on platforms where this is
superfluous

[bbudge, 2012-12-01 16:12:38]

https://codereview.chromium.org/11412293/diff/1/ppapi/proxy/plugin_main_nacl.cc
File ppapi/proxy/plugin_main_nacl.cc (right):

https://codereview.chromium.org/11412293/diff/1/ppapi/proxy/plugin_main_nacl....
ppapi/proxy/plugin_main_nacl.cc:231: IrtInit();
On 2012/12/01 14:48:47, dmichael wrote:
> I assume you verified that it's okay to call it twice on platforms where this
is
> superfluous

Yes. It's idempotent.

[commit-bot: I haz the power, 2012-12-01 16:13:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/11412293/1

[commit-bot: I haz the power, 2012-12-01 18:20:05]

Change committed as 170671

[Mark Seaborn, 2012-12-01 20:07:50]

Why does this behave differently on ARM?

IrtInit() is supposed to be called by a constructor function (declared with
__attribute__((constructor))).  If constructor functions aren't working in the
PNaCl/IRT build, we should fix that.  It might cause other failures inside the
PPAPI proxy.

[bbudge, 2012-12-01 21:54:34]

On 2012/12/01 20:07:50, Mark Seaborn wrote:
> Why does this behave differently on ARM?
> 
> IrtInit() is supposed to be called by a constructor function (declared with
> __attribute__((constructor))).  If constructor functions aren't working in the
> PNaCl/IRT build, we should fix that.  It might cause other failures inside the
> PPAPI proxy.

Yes, that's a good point. I noticed that the old proxy also calls IrtInit() in
its PpapiPluginMain function, and I wanted to get the proxy working ASAP. On
other platforms, IrtInit is definitely called by the platform startup code. We
should definitely figure out why this isn't working on the ARM build.