[android_webview] Fix crash in ContentViewCore/ContentSettings.

[android_webview] Fix crash in ContentViewCore/ContentSettings.

Apparently it's possible for mHandler to run after .destroy has
been called on mContentViewCore.
Since the ContentViewCore.destroy() documentation states that no
other methods may be called on it after destroy() it seems like
the right fix is to add a check to the handler.

BUG=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170964

[mnaganov (inactive), 2012-12-03 12:35:16]

LGTM once you fix the style.

https://codereview.chromium.org/11412273/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentSettings.java
(right):

https://codereview.chromium.org/11412273/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentSettings.java:114:
if (mContentViewCore.isAlive())
nit: This seems to violate Java style guide
(http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-1...)

[mkosiba (inactive), 2012-12-03 17:21:17]

https://codereview.chromium.org/11412273/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentSettings.java
(right):

https://codereview.chromium.org/11412273/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentSettings.java:114:
if (mContentViewCore.isAlive())
On 2012/12/03 12:35:16, Mikhail Naganov (Chromium) wrote:
> nit: This seems to violate Java style guide
>
(http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-1...)

thanks for pointing that out!

[commit-bot: I haz the power, 2012-12-03 17:21:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/11412273/5002

[commit-bot: I haz the power, 2012-12-03 17:21:36]

Presubmit check for 11412273-5002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/public/android

Presubmit checks took 1.0s to calculate.

[mkosiba (inactive), 2012-12-03 19:04:26]

Marcus, OWNERs lgtm please?

[bulach, 2012-12-03 20:05:12]

lgtm, not my area but one suggestion regardless:

https://chromiumcodereview.appspot.com/11412273/diff/5002/content/public/andr...
File
content/public/android/java/src/org/chromium/content/browser/ContentSettings.java
(right):

https://chromiumcodereview.appspot.com/11412273/diff/5002/content/public/andr...
content/public/android/java/src/org/chromium/content/browser/ContentSettings.java:114:
if (mContentViewCore.isAlive()) {
how about move this check to ContentViewCore itself? seems it'd be better than
call two methods at it..

[mkosiba (inactive), 2012-12-04 10:37:21]

@bulach - the ContentViewCore docs clearly state that clients should not call
methods on the object after .destroy() has been called.

[commit-bot: I haz the power, 2012-12-04 10:45:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/11412273/5002

[commit-bot: I haz the power, 2012-12-04 15:44:02]

Change committed as 170964