Issue 11412272: [v8-dev] ARM: Improve double to integer truncation on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412272: [v8-dev] ARM: Improve double to integer truncation on ARM. (Closed)

Created:
8 years ago by Rodolph Perfetta

Modified:
8 years ago

Reviewers:
ulan, danno

CC:
v8-dev, hans

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Improve double to integer truncation on ARM. BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=13162

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -17 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1	2 chunks	+9 lines, -1 line	1 comment	Download
M	src/arm/macro-assembler-arm.cc	View	1	4 chunks	+22 lines, -10 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

8 years ago (2012-12-05 15:43:15 UTC) #2

LGTM, I will land it for you after I check benchmark results for Nexus 4.

https://chromiumcodereview.appspot.com/11412272/diff/6001/src/arm/macro-assem...
File src/arm/macro-assembler-arm.h (right):

https://chromiumcodereview.appspot.com/11412272/diff/6001/src/arm/macro-assem...
src/arm/macro-assembler-arm.h:964: // 'result' contains the integer value.
Otherwise the code fall trough.
Minor nit: should be ", the code jumps" and ", the code falls through".

Expand Messages | Collapse Messages