Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 11412269: Add more tsan suppression for ffmpeg related failures. (Closed)

Created:
8 years ago by xhwang
Modified:
8 years ago
CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M tools/valgrind/tsan/suppressions_win32.txt View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xhwang
PTAL!
8 years ago (2012-11-30 06:12:58 UTC) #1
Alexander Potapenko
On 2012/11/30 06:12:58, xhwang wrote: > PTAL! LGTM
8 years ago (2012-11-30 07:52:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/11412269/2001
8 years ago (2012-11-30 07:55:40 UTC) #3
commit-bot: I haz the power
Presubmit check for 11412269-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-11-30 07:55:45 UTC) #4
Alexander Potapenko
+phajdan.jr Paweł, could your https://codereview.chromium.org/11421163/ be related to the presubmit failure?
8 years ago (2012-11-30 08:00:46 UTC) #5
Paweł Hajdan Jr.
8 years ago (2012-11-30 16:50:43 UTC) #6
On 2012/11/30 08:00:46, Alexander Potapenko wrote:
> +phajdan.jr
> Paweł, could your https://codereview.chromium.org/11421163/ be related to the
> presubmit failure?

It may be.  src/tools/python/google/path_utils.py needs to be in PYTHONPATH for
that to work.

Powered by Google App Engine
This is Rietveld 408576698