Add usage display support for Extension IME.

Add usage display support for Extension IME.

In the case of Japanese, IME shows word usage or its description. This
feature is already supported in Chrome OS native ibus IME engines.
With this patch, Chrome supports same feature for Extension IME.

This change does not affect existing extension implementation in terms of
backward compatibility.

BUG=158486
TEST=manually done one lumpy.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170670

[Zachary Kuznia, 2012-11-30 06:47:20]

lgtm

[Seigo Nonaka, 2012-11-30 07:01:05]

Adding mpcomplete@ as the owner of extension api.

Could you take a look?

Thank you.

[Matt Perry, 2012-11-30 20:38:08]

lgtm

https://codereview.chromium.org/11412268/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/input_ime/input_ime_api.cc (right):

https://codereview.chromium.org/11412268/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/input_ime/input_ime_api.cc:685:
usage_dict->HasKey(keys::kUsageBodyKey)) {
Looking at the json, "title" and "body" are not optional properties. You should
remove the HasKey checks.

[Seigo Nonaka, 2012-12-01 15:31:18]

Thank you for your review!

https://codereview.chromium.org/11412268/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/input_ime/input_ime_api.cc (right):

https://codereview.chromium.org/11412268/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/input_ime/input_ime_api.cc:685:
usage_dict->HasKey(keys::kUsageBodyKey)) {
On 2012/11/30 20:38:08, Matt Perry wrote:
> Looking at the json, "title" and "body" are not optional properties. You
should
> remove the HasKey checks.

Done.

[commit-bot: I haz the power, 2012-12-01 15:31:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11412268/6002

[commit-bot: I haz the power, 2012-12-01 18:10:47]

Change committed as 170670