Issue 11412265: Fix Aura Release compile break in metro_driver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412265: Fix Aura Release compile break in metro_driver. (Closed)

Created:
8 years ago by grt (UTC plus 2)

Modified:
8 years ago

Reviewers:
cpu_(ooo_6.6-7.5), robertshield

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Aura Release compile break in metro_driver. The breakpad export has been unused for the last five months, so I suppose it's safe to remove it entirely. BUG=162405 TEST=Chromium Win (aura) bot should be able to compile metro_driver.dll. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170555

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	win8/metro_driver/chrome_app_view.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
	M	win8/metro_driver/metro_driver.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

grt (UTC plus 2)

Montreal calling. (doesn't sound quite as snappy as London calling.)

8 years ago (2012-11-30 02:53:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/11412265/1

8 years ago (2012-11-30 19:41:37 UTC) #3

Message was sent while issue was closed.

Change committed as 170555

Expand Messages | Collapse Messages