Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 11412264: Fixed full screen magnifier switching in oobe. (Closed)

Created:
8 years ago by mtomasz
Modified:
8 years ago
CC:
chromium-reviews, zork+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Fixed full screen magnifier switching in oobe. Before full screen magnifier was enabled by default, instead of disabled. Also, it didn't listen to state switches. This patch addresses these issues. BUG=163147 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170956

Patch Set 1 #

Patch Set 2 : Fixed tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
mtomasz
8 years ago (2012-11-30 02:33:06 UTC) #1
mtomasz
@yoshiki: PTAL carefully. I just removed 4 lines which I didn't understand, but it solves ...
8 years ago (2012-11-30 02:33:55 UTC) #2
yoshiki
LGTM On 2012/11/30 02:33:55, mtomasz wrote: > @yoshiki: PTAL carefully. I just removed 4 lines ...
8 years ago (2012-11-30 08:33:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/11412264/1
8 years ago (2012-11-30 17:11:39 UTC) #4
commit-bot: I haz the power
Presubmit check for 11412264-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-11-30 17:11:47 UTC) #5
mtomasz
8 years ago (2012-11-30 18:24:44 UTC) #6
mtomasz
@zork: PTAL, I need your lgtm.
8 years ago (2012-11-30 18:24:50 UTC) #7
Zachary Kuznia
lgtm
8 years ago (2012-12-03 07:20:03 UTC) #8
yoshiki
@mtomasz: Sorry I forgot to say. This CL may break test. Please modify magnification_manager_browsertest.cc as ...
8 years ago (2012-12-03 07:31:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/11412264/5003
8 years ago (2012-12-03 20:26:34 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-03 22:20:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/11412264/5003
8 years ago (2012-12-03 22:23:59 UTC) #12
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 02:32:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/11412264/5003
8 years ago (2012-12-04 13:40:41 UTC) #14
commit-bot: I haz the power
8 years ago (2012-12-04 15:23:48 UTC) #15
Message was sent while issue was closed.
Change committed as 170956

Powered by Google App Engine
This is Rietveld 408576698