Removed dead code from chrome/browser/extensions/api/declarative

chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative/rules_registry_with_cache.h"
 
 #include "base/logging.h"
 #include "base/stringprintf.h"
 
 namespace {
 
 const char kSuccess[] = "";
 const char kDuplicateRuleId[] = "Duplicate rule ID: %s";
 
 }  // namespace
 
 namespace extensions {
 
 RulesRegistryWithCache::RulesRegistryWithCache(Delegate* delegate)
     : delegate_(delegate) {
 }
 
-void RulesRegistryWithCache::AddReadyCallback(const base::Closure& callback) {
-  ready_callbacks_.push_back(callback);
-}
-
 void RulesRegistryWithCache::OnReady() {
   for (size_t i = 0; i < ready_callbacks_.size(); ++i)
     ready_callbacks_[i].Run();
   ready_callbacks_.clear();

[battre, 2012/12/01 02:27:54]

I think this is now broken. You cannot add read_callbacks_ anymore but we try to
trigger them here.

I don't have a working code index right now. We should check whether OnReady()
gets called by anybody. If this is the case, we should consider whether it is
necessary or whether we are dealing with a bug here. I am kind of expecting that
but haven't had the time to research, yet.

[Matt Perry, 2012/12/03 17:56:19]

I should've looked at this more closely. There's a caller of AddReadyCallback
here:
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/extensions/...

It's behind an #ifdef, so it doesn't actually compile. But I believe we will
eventually want to flip the #ifdef to ON.

We should revert this change.

 }
 
 std::string RulesRegistryWithCache::AddRules(
     const std::string& extension_id,
     const std::vector<linked_ptr<Rule> >& rules) {
   DCHECK(content::BrowserThread::CurrentlyOn(GetOwnerThread()));
 
   // Verify that all rule IDs are new.
   for (std::vector<linked_ptr<Rule> >::const_iterator i =
       rules.begin(); i != rules.end(); ++i) {
@@ skipping 105 matching lines @@
     const std::string& extension_id) {
   DCHECK(content::BrowserThread::CurrentlyOn(GetOwnerThread()));
 
   if (delegate_.get())
     delegate_->OnRulesChanged(this, extension_id);
 }
 
 RulesRegistryWithCache::~RulesRegistryWithCache() {}
 
 }  // namespace extensions