Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Issue 11412239: Delay determination of why a synced disabled extension was disabled. (Closed)

Created:
8 years ago by Yoyo Zhou
Modified:
8 years ago
Reviewers:
akalin, Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Delay determination of why a synced disabled extension was disabled. Also simplify handling of legacy disabled extensions. BUG=162062 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171072

Patch Set 1 #

Patch Set 2 : error showing #

Patch Set 3 : test and fix #

Patch Set 4 : missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -15 lines) Patch
M chrome/browser/extensions/extension_disabled_ui_browsertest.cc View 1 2 2 chunks +56 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 4 chunks +24 lines, -14 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/permissions_increase/updates.xml View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/permissions_increase/v1/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/permissions_increase/v2/manifest.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/permissions_increase/v3/manifest.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoyo Zhou
Do you know of any tests I could look at emulating that install an extension ...
8 years ago (2012-11-29 02:43:59 UTC) #1
akalin
On 2012/11/29 02:43:59, Yoyo Zhou wrote: > Do you know of any tests I could ...
8 years ago (2012-11-30 00:33:35 UTC) #2
Yoyo Zhou
Unsurprisingly, adding a test showed that my first attempt was incorrect. Sadly, it's more correct ...
8 years ago (2012-12-01 00:54:07 UTC) #3
akalin
On 2012/12/01 00:54:07, Yoyo Zhou wrote: > Unsurprisingly, adding a test showed that my first ...
8 years ago (2012-12-04 17:21:12 UTC) #4
Yoyo Zhou
+mpcomplete
8 years ago (2012-12-04 18:21:54 UTC) #5
Matt Perry
lgtm
8 years ago (2012-12-04 18:31:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/11412239/7009
8 years ago (2012-12-04 19:37:57 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-04 22:53:51 UTC) #8
Message was sent while issue was closed.
Change committed as 171072

Powered by Google App Engine
This is Rietveld 408576698