Issue 11412162: Remove unused heap debug utils code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412162: Remove unused heap debug utils code. (Closed)

Created:
8 years ago by ulan

Modified:
8 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove unused heap debug utils code. This functionality is already implemented by PathTracer. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13052

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -181 lines)			Patch
	M	src/heap.h	View		2 chunks	+0 lines, -8 lines	2 comments	Download
	M	src/heap.cc	View		4 chunks	+0 lines, -173 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years ago (2012-11-26 10:09:57 UTC) #2

Only red lines, that's an instant LGTM (with a few nits).

https://chromiumcodereview.appspot.com/11412162/diff/1/src/heap.h
File src/heap.h (right):

https://chromiumcodereview.appspot.com/11412162/diff/1/src/heap.h#newcode289
src/heap.h:289: 
Drop the third empty newline.

https://chromiumcodereview.appspot.com/11412162/diff/1/src/heap.h#newcode1789
src/heap.h:1789: 
Drop the empty newline.

Expand Messages | Collapse Messages