Rollback UpgradeToHttps for viewvc links

Rollback UpgradeToHttps for viewvc links

- Many chrome-internal viewvc links do not support https.  UpgradeToHttps
  was added 10 months ago  and continues to generate broken viewvc links.

Reverts part of crrev.com/9214004

BUG=107838
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169815

[nsylvain, 2012-11-25 22:17:17]

lgtm

[M-A Ruel, 2012-11-26 15:59:02]

Could we make a whitelist of the ones we know are safe instead? I don't have
much opinion but Chris probably has. :) In any way, broken urls are useless so
something must be done, but a blacklist or whitelist would be nice. If you don't
want to leak all the urls, you use a salted sha-1 of the urls.

[Isaac (away), 2012-11-26 18:45:16]

Better than a whilelist would probably be to switch all the chrome-internal
viewvc links to a supported scheme.  On some of the repo's we've used

goto.google.com/viewvc

which supports https and will eventually point to
https://uberchromegw.corp.google.com

However, this patch is to fix the breakage, not to deal with the security
aspects.

[palmer, 2012-11-26 19:06:27]

What is the impact of this? I don't know that I've ever seen a viewvc link,
either broken or working.

In general, the approach to this kind of problem should be to make HTTPS work on
the affected service — HTTP should be deprecated except for use as an introducer
protocol for HTTPS.

[Isaac (away), 2012-11-26 19:09:26]

Viewvc links are the links in svn/git log that say

Committed: <url>

They all get put in the descriptions on rietveld and get propagated to crbugs by
bugdroid.

[Isaac (away), 2012-11-26 19:09:48]

s/all/also

[palmer, 2012-11-26 19:14:15]

> Viewvc links are the links in svn/git log that say
> 
> Committed: <url>
> 
> They all get put in the descriptions on rietveld and get propagated to crbugs
by
> bugdroid.

Oh, I see.

This change is OK with me if we also prioritize upgrading services to support
HTTPS. Can we do that? What are the barriers?

[commit-bot: I haz the power, 2012-11-28 02:04:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/11412161/5

[commit-bot: I haz the power, 2012-11-28 02:06:50]

Change committed as 169815