Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 11412151: Fix use of FindTabbedBrowser when handling windows.create calls. (Closed)

Created:
8 years, 1 month ago by grt (UTC plus 2)
Modified:
8 years ago
Reviewers:
Aaron Boodman, scottmg
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix use of FindTabbedBrowser when handling windows.create calls. In practice, this particular call to FindTabbedBrowser will only happen for Ash-in-metro, so using the default host desktop type (as was done in http://crrev.com/168064) is guaranteed to be the wrong choice. Forcing HOST_DESKTOP_TYPE_ASH would be correct for this specific case, but using the currently active desktop (which will always be Ash) will also work and is more consistent with other places where a browser needs to be found. BUG=129187 TBR=aa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/api/tabs/tabs.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
Scott: please review for correctness (you reviewed the previous change by tfarina here). Aaron: please ...
8 years, 1 month ago (2012-11-22 16:56:57 UTC) #1
scottmg
On 2012/11/22 16:56:57, grt wrote: > Scott: please review for correctness (you reviewed the previous ...
8 years, 1 month ago (2012-11-23 17:14:14 UTC) #2
grt (UTC plus 2)
On 2012/11/23 17:14:14, scottmg wrote: > On 2012/11/22 16:56:57, grt wrote: > > Scott: please ...
8 years, 1 month ago (2012-11-23 18:24:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/11412151/1
8 years ago (2012-11-29 13:58:56 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-11-29 15:03:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/11412151/1
8 years ago (2012-11-30 02:57:00 UTC) #6
commit-bot: I haz the power
8 years ago (2012-11-30 05:52:34 UTC) #7
Message was sent while issue was closed.
Change committed as 170412

Powered by Google App Engine
This is Rietveld 408576698