Issue 11412128: Android: Fix PathUtilsTest.TestGetNativeLibraryDirectory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412128: Android: Fix PathUtilsTest.TestGetNativeLibraryDirectory (Closed)

Created:
8 years, 1 month ago by John Knottenbelt

Modified:
8 years, 1 month ago

Reviewers:
bulach

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: Fix PathUtilsTest.TestGetNativeLibraryDirectory Instead of checking for a specific directory, check that the returned directory contains a the base unit tests .so file. This should allow the test to work on recent Jelly Bean build and make it less fragile in general. TEST=base_unittest:PathUtilsTest.TestGetNativeLibraryDirectory BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169037

Patch Set 1 #

Total comments: 1

Patch Set 2 : Check for the base unit tests so #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	base/android/path_utils_unittest.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, small suggestion below: https://codereview.chromium.org/11412128/diff/1/base/android/path_utils_unittest.cc File base/android/path_utils_unittest.cc (right): https://codereview.chromium.org/11412128/diff/1/base/android/path_utils_unittest.cc#newcode49 base/android/path_utils_unittest.cc:49: "*.so"); maybe best to check ...

8 years, 1 month ago (2012-11-21 12:04:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/11412128/5002

8 years, 1 month ago (2012-11-21 12:22:37 UTC) #4

Change committed as 169037

Expand Messages | Collapse Messages