Issue 11412120: MIPS: Support all fast elements kinds in the major array operations. Currently missing support for …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412120: MIPS: Support all fast elements kinds in the major array operations. Currently missing support for … (Closed)

Created:
8 years, 1 month ago by palfia

Modified:
8 years, 1 month ago

Reviewers:
kisg, Paul Lind, danno, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Support all fast elements kinds in the major array operations. Currently missing support for unshift. Port r12969 (b10320d7) BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=13022

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -15 lines)			Patch
M	src/mips/code-stubs-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/ic-mips.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	6 chunks	+40 lines, -5 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

palfia

https://chromiumcodereview.appspot.com/11412120/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/11412120/diff/1/src/objects-inl.h#newcode1947 src/objects-inl.h:1947: return reinterpret_cast<double*>(FIELD_ADDR(this, kHeaderSize)); I've modified this line, because the ...

8 years, 1 month ago (2012-11-21 00:50:50 UTC) #1

lgtm, landing.

Expand Messages | Collapse Messages