Support VTune's JIT interface.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
@@ skipping 14 matching lines @@
 #include "vm/growable_array.h"
 #include "vm/heap.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/runtime_entry.h"
 #include "vm/scopes.h"
 #include "vm/stack_frame.h"
 #include "vm/symbols.h"
 #include "vm/timer.h"
 #include "vm/unicode.h"
+#include "vm/vtune.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, generate_gdb_symbols, false,
     "Generate symbols of generated dart functions for debugging with GDB");
 DEFINE_FLAG(bool, show_internal_names, false,
     "Show names of internal classes (e.g. \"OneByteString\") in error messages "
     "instead of showing the corresponding interface names (e.g. \"String\")");
 DEFINE_FLAG(bool, trace_disabling_optimized_code, false,
     "Trace disabling optimized code.");
@@ skipping 6995 matching lines @@
       OS::SNPrint(pname, (len + 1), kFormat, name, "entry");
       DebugInfo::RegisterSection(pname, instrs.EntryPoint(), prolog_offset);
       DebugInfo::RegisterSection(name,
                                  (instrs.EntryPoint() + prolog_offset),
                                  (instrs.size() - prolog_offset));
     } else {
       DebugInfo::RegisterSection(name, instrs.EntryPoint(), instrs.size());
     }
   }
 
+  VTune::Register(name, instrs.EntryPoint(), instrs.size());

[Ivan Posva, 2012/11/26 04:36:38]

We should really clean this up. The different tools should be supported outside
of this method in something like RegisterInTools. Does not have to happen in
this CL, but if you do not factor this out before the end of the week, please
file a tracking bug.

[Vyacheslav Egorov (Google), 2012/11/26 15:11:10]

Refactored.

+
   const ZoneGrowableArray<int>& pointer_offsets =
       assembler->GetPointerOffsets();
 
   // Allocate the code object.
   Code& code = Code::ZoneHandle(Code::New(pointer_offsets.length()));
   {
     NoGCScope no_gc;
 
     // Set pointer offsets list in Code object and resolve all handles in
     // the instruction stream to raw objects.
@@ skipping 12 matching lines @@
   return code.raw();
 }
 
 
 RawCode* Code::FinalizeCode(const Function& function,
                             Assembler* assembler,
                             bool optimized) {
   // Calling ToFullyQualifiedCString is very expensive, try to avoid it.
   if (FLAG_generate_gdb_symbols ||
       Dart::perf_events_writer() != NULL ||
-      Dart::pprof_symbol_generator() != NULL) {
+      Dart::pprof_symbol_generator() != NULL ||
+      VTune::IsActive()) {

[Ivan Posva, 2012/11/26 04:36:38]

This seems rather error prone, as the checking is done at two places. Falls into
the same category as above.

[Vyacheslav Egorov (Google), 2012/11/26 15:11:10]

Refactored.

     return FinalizeCode(function.ToFullyQualifiedCString(),
                         assembler,
                         optimized);
   } else {
     return FinalizeCode("", assembler);
   }
 }
 
 
 // Check if object matches find condition.
@@ skipping 4910 matching lines @@
   }
   return result.raw();
 }
 
 
 const char* WeakProperty::ToCString() const {
   return "_WeakProperty";
 }
 
 }  // namespace dart