Fix and enable the PAC fetcher NoCache test on Android

Fix and enable the PAC fetcher NoCache test on Android

The NoCache test for the PAC fetcher verifies that an attempt to
fetch a PAC script fails once the server is killed, thus assuring
that PAC files are not cached.

Due to the device-server / port forwarding layout of running 
gtests on Android, the specific error being returned by the 
fetch attempt is "Connection reset by peer" rather than 
"Connection refused". This patch takes this into consideration.

BUG=161763
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168805

[eroman, 2012-11-20 00:26:57]

lgtm

https://codereview.chromium.org/11412070/diff/4/net/proxy/proxy_script_fetche...
File net/proxy/proxy_script_fetcher_impl_unittest.cc (right):

https://codereview.chromium.org/11412070/diff/4/net/proxy/proxy_script_fetche...
net/proxy/proxy_script_fetcher_impl_unittest.cc:323: // See:
https://codereview.chromium.org/118032/
We typically don't link to codereviews.

You could get SVN history to see the codereview which added it.

[ppi, 2012-11-20 10:41:31]

Good point - fixed. Thanks a lot!

On 2012/11/20 00:26:57, eroman wrote:
> lgtm
> 
>
https://codereview.chromium.org/11412070/diff/4/net/proxy/proxy_script_fetche...
> File net/proxy/proxy_script_fetcher_impl_unittest.cc (right):
> 
>
https://codereview.chromium.org/11412070/diff/4/net/proxy/proxy_script_fetche...
> net/proxy/proxy_script_fetcher_impl_unittest.cc:323: // See:
> https://codereview.chromium.org/118032/
> We typically don't link to codereviews.
> 
> You could get SVN history to see the codereview which added it.

[Philippe, 2012-11-20 13:17:22]

lgtm, thanks Przemek!

[ppi, 2012-11-20 13:21:28]

Thanks Philippe!

On 2012/11/20 13:17:22, Philippe wrote:
> lgtm, thanks Przemek!

[commit-bot: I haz the power, 2012-11-20 13:21:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/11412070/1003

[commit-bot: I haz the power, 2012-11-20 15:16:09]

Change committed as 168805