Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 11412067: [rlz,cros] RLZ glue for ChromeOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index f5e408a34a3f2a485992c6b610312bb6424b4d14..09c16fc6137360bd6f0725ba1da3d73b0f146ce3 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -8,7 +8,6 @@
#include <gtk/gtk.h>
#endif
-#include <algorithm>
#include <string>
#include <vector>
@@ -419,12 +418,6 @@ bool HasImportSwitch(const CommandLine& command_line) {
command_line.HasSwitch(switches::kImportFromFile));
}
-#if defined(ENABLE_RLZ)
-bool IsGoogleUrl(const GURL& url) {
- return google_util::IsGoogleHomePageUrl(url.possibly_invalid_spec());
-}
-#endif
-
} // namespace
namespace chrome_browser {
@@ -1205,44 +1198,13 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
#endif // OS_WIN
#if defined(ENABLE_RLZ) && !defined(OS_CHROMEOS)
- // TODO(ivankr): do this on user login on ChromeOS.
// Init the RLZ library. This just binds the dll and schedules a task on the
// file thread to be run sometime later. If this is the first run we record
// the installation event.
- bool is_google_default_search = false;
- TemplateURLService* template_url_service =
- TemplateURLServiceFactory::GetForProfile(profile_);
- if (template_url_service) {
- const TemplateURL* url_template =
- template_url_service->GetDefaultSearchProvider();
- is_google_default_search =
- url_template && url_template->url_ref().HasGoogleBaseURLs();
- }
-
PrefService* pref_service = profile_->GetPrefs();
- bool is_google_homepage = google_util::IsGoogleHomePageUrl(
- pref_service->GetString(prefs::kHomePage));
-
- bool is_google_in_startpages = false;
- SessionStartupPref session_startup_prefs =
- StartupBrowserCreator::GetSessionStartupPref(parsed_command_line(),
- profile_);
- if (session_startup_prefs.type == SessionStartupPref::URLS) {
- is_google_in_startpages = std::count_if(session_startup_prefs.urls.begin(),
- session_startup_prefs.urls.end(),
- IsGoogleUrl) > 0;
- }
-
int ping_delay = is_first_run_ ? master_prefs_->ping_delay :
pref_service->GetInteger(first_run::GetPingDelayPrefName().c_str());
- RLZTracker::InitRlzDelayed(is_first_run_, ping_delay,
- is_google_default_search, is_google_homepage,
- is_google_in_startpages);
-
- // Prime the RLZ cache for the home page access point so that its avaiable
- // for the startup page if needed (i.e., when the startup page is set to
- // the home page).
- RLZTracker::GetAccessPointRlz(RLZTracker::CHROME_HOME_PAGE, NULL);
+ RLZTracker::InitRlzFromProfileDelayed(profile_, is_first_run_, ping_delay);
#endif // defined(ENABLE_RLZ) && !defined(OS_CHROMEOS)
// Configure modules that need access to resources.
« no previous file with comments | « chrome/browser/automation/testing_automation_provider_chromeos.cc ('k') | chrome/browser/chromeos/login/eula_screen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698