Automatically sort headers in files affected by move_source_file.py

Automatically sort headers in files affected by move_source_file.py, and update full-path references in // comments.

Sorting headers does not seem to affect timing appreciably in my test case, but searching for full-path references in comments does increase the time taken by around 20%.  If the speed ever becomes a problem, this latter feature could be made optional, but for now it is probably simplest to leave it on all the time.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169252

[Jói, 2012-11-15 15:29:51]

Nico, as discussed, this follow-up to http://codereview.chromium.org/11358216/
adds automatic sorting of headers in modified files.

Cheers,
Jói

[Jói, 2012-11-20 14:52:07]

Updated this follow-up change, and its description, to include updating
full-path references in // comments.

Cheers,
Jói

[Jói, 2012-11-21 14:04:26]

Switched to the simpler interface you proposed for MultiFileFindReplace.  Much
nicer this way, and faster than multiple passes of string.replace()

Cheers,
Jói

[Nico, 2012-11-21 18:35:35]

Nice! lgtm

https://codereview.chromium.org/11412006/diff/5004/tools/git/move_source_file.py
File tools/git/move_source_file.py (right):

https://codereview.chromium.org/11412006/diff/5004/tools/git/move_source_file...
tools/git/move_source_file.py:119: for changed_file in
files_with_changed_includes:
I'd do `def auto_confirm(a, b): return true; FixFileWithConfrim(changed_file,
always_confirm)`, that's a bit more readable than the lambda imo.

https://codereview.chromium.org/11412006/diff/5004/tools/git/move_source_file...
tools/git/move_source_file.py:127: ['*.cc', '*.h', '*.m', '*.mm'])
I'd omit this as I said. It only finds comments that contain the full file path,
and comments with filenames aren't super common. Imho this isn't worth 20%.

(But searching crbug.com for "//.*[/].*\w\.cc -file:v8 -file:third_party" finds
more than I thought it would, so up to you.)

[Jói, 2012-11-22 09:42:50]

https://codereview.chromium.org/11412006/diff/5004/tools/git/move_source_file.py
File tools/git/move_source_file.py (right):

https://codereview.chromium.org/11412006/diff/5004/tools/git/move_source_file...
tools/git/move_source_file.py:119: for changed_file in
files_with_changed_includes:
On 2012/11/21 18:35:36, Nico wrote:
> I'd do `def auto_confirm(a, b): return true; FixFileWithConfrim(changed_file,
> always_confirm)`, that's a bit more readable than the lambda imo.

Done.

https://codereview.chromium.org/11412006/diff/5004/tools/git/move_source_file...
tools/git/move_source_file.py:127: ['*.cc', '*.h', '*.m', '*.mm'])
On 2012/11/21 18:35:36, Nico wrote:
> I'd omit this as I said. It only finds comments that contain the full file
path,
> and comments with filenames aren't super common. Imho this isn't worth 20%.
> 
> (But searching http://crbug.com for "//.*[/].*\w\.cc -file:v8
-file:third_party" finds
> more than I thought it would, so up to you.)

I'll leave it in since it's safe and convenient and updates something you might
not remember to search for and update yourself.  I've added a comment
documenting that comment handling is somewhat slow and the script could be sped
up by making it optional under a flag; time will tell if it is fast enough or
not.

[commit-bot: I haz the power, 2012-11-22 09:43:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/11412006/5005

[commit-bot: I haz the power, 2012-11-22 11:29:01]

Change committed as 169252