Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 11411358: LabelButton: Set the label's disabled status to match that of the button (Closed)

Created:
8 years ago by bartfab (slow)
Modified:
8 years ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

LabelButton: Set the label's disabled status to match that of the button The LabelButton hosts a Label to paints its text content. When the button is disabled, that Label needs to be disabled as well so that it can paint itself grayed out. BUG=155363, 162729 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bartfab (slow)
Hi Sadrul, Can you please review?
8 years ago (2012-12-04 16:11:39 UTC) #1
sadrul
LGTM. thanks!
8 years ago (2012-12-04 16:13:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11411358/1
8 years ago (2012-12-04 16:16:25 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-04 19:12:11 UTC) #4
Message was sent while issue was closed.
Change committed as 171016

Powered by Google App Engine
This is Rietveld 408576698