Issue 11411346: Bookmark: change Move() with no effect to keep the folder timestamp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411346: Bookmark: change Move() with no effect to keep the folder timestamp. (Closed)

Created:
8 years ago by kinaba

Modified:
8 years ago

Reviewers:
sky

CC:
chromium-reviews, browser-components-watch_chromium.org, Nicolas Zea

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Bookmark: change Move() with no effect to keep the folder timestamp. Bookmark Sync may try to Move an entry to the location where it already is placed. Updating the folder's timestamp with such no-op moves unwillingly disorders the "recently used" list of folders; it should better be avoided. BUG=162764 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171134

Patch Set 1 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	chrome/browser/bookmarks/bookmark_model.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/11411346/3001

8 years ago (2012-12-04 23:41:40 UTC) #3

Message was sent while issue was closed.

Change committed as 171134

Expand Messages | Collapse Messages