Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11411324: Exclude chrome/common/extensions/api/ from build if enable_extensions==0 (Closed)

Created:
8 years ago by nilesh
Modified:
8 years ago
Reviewers:
Yoyo Zhou, Jay Civelli, Nico
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, stuartmorgan
Visibility:
Public.

Description

Exclude chrome/common/extensions/api/ from build if enable_extensions==0 BUG=155069 Saves 170k in libchromeview.so Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170962

Patch Set 1 #

Patch Set 2 : Exclude test #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M chrome/chrome_common.gypi View 1 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/api/extension_api_stub.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
nilesh
8 years ago (2012-12-03 19:57:53 UTC) #1
Yoyo Zhou
LGTM, please fix typo (commom->common) in CL description.
8 years ago (2012-12-03 20:09:22 UTC) #2
nilesh
Adding Nico for chrome/*.gyp
8 years ago (2012-12-03 21:38:47 UTC) #3
Nico
lgtm https://codereview.chromium.org/11411324/diff/9002/chrome/common/extensions/api/extension_api_stub.cc File chrome/common/extensions/api/extension_api_stub.cc (right): https://codereview.chromium.org/11411324/diff/9002/chrome/common/extensions/api/extension_api_stub.cc#newcode6 chrome/common/extensions/api/extension_api_stub.cc:6: Please add a comment here that explains why ...
8 years ago (2012-12-03 21:40:37 UTC) #4
nilesh
On 2012/12/03 21:40:37, Nico wrote: > lgtm > > https://codereview.chromium.org/11411324/diff/9002/chrome/common/extensions/api/extension_api_stub.cc > File chrome/common/extensions/api/extension_api_stub.cc (right): > ...
8 years ago (2012-12-03 22:40:57 UTC) #5
nilesh
https://codereview.chromium.org/11411324/diff/9002/chrome/common/extensions/api/extension_api_stub.cc File chrome/common/extensions/api/extension_api_stub.cc (right): https://codereview.chromium.org/11411324/diff/9002/chrome/common/extensions/api/extension_api_stub.cc#newcode6 chrome/common/extensions/api/extension_api_stub.cc:6: On 2012/12/03 21:40:38, Nico wrote: > Please add a ...
8 years ago (2012-12-03 22:41:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11411324/11003
8 years ago (2012-12-03 22:51:00 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-04 02:45:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11411324/11003
8 years ago (2012-12-04 05:41:03 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 08:04:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11411324/11003
8 years ago (2012-12-04 14:39:46 UTC) #11
commit-bot: I haz the power
8 years ago (2012-12-04 15:34:24 UTC) #12
Message was sent while issue was closed. 
Change committed as 170962

Powered by Google App Engine
This is Rietveld 408576698