Correct misleading definition of 'closure' in base/bind documentation.

Correct misleading definition of 'closure' in base/bind documentation.

Also move groby's doc update (https://chromiumcodereview.appspot.com/11091056/)
into the source file from the generated file.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171549

[Patrick Dubroy, 2012-12-03 18:00:23]

Please take a look. It's just a small documentation update -- the definition of
"closure" was not quite right, and I think it was confusing for people who are
familiar with the term in other languages.

[commit-bot: I haz the power, 2012-12-03 19:01:26]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[willchan no longer on Chromium, 2012-12-03 19:15:43]

lgtm

[commit-bot: I haz the power, 2012-12-03 19:16:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dubroy@chromium.org/11411319/1

[awong, 2012-12-03 19:27:07]

On 2012/12/03 19:16:27, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/dubroy%40chromium.org/11411319/1

LGTM

Thanks!  New wording is indeed more accurate.

(silly rietveld)

[commit-bot: I haz the power, 2012-12-03 21:17:06]

Retried try job too often on linux_rel for step(s) content_unittests

[awong, 2012-12-04 08:12:16]

LGTM

Thanks!  New wording is indeed more accurate.

On Mon, Dec 3, 2012 at 10:00 AM, <dubroy@chromium.org> wrote:

> Reviewers: awong, willchan,
>
> Message:
> Please take a look. It's just a small documentation update -- the
> definition of
> "closure" was not quite right, and I think it was confusing for people who
> are
> familiar with the term in other languages.
>
> Description:
> Correct misleading definition of 'closure' in base/bind documentation.
>
> Also move groby's doc update (https://chromiumcodereview.**
> appspot.com/11091056/ <https://chromiumcodereview.appspot.com/11091056/>)
> into the source file from the generated file.
>
> BUG=
>
>
> Please review this at
https://codereview.chromium.**org/11411319/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M base/callback.h
>   M base/callback.h.pump
>
>
> Index: base/callback.h
> diff --git a/base/callback.h b/base/callback.h
> index 594c9d6244b6b0b45b7e6903d0a325**9f77665ce2..**
> ade3f8c1fc000ab7267fecbd69a3f5**31bb7ba83b 100644
> --- a/base/callback.h
> +++ b/base/callback.h
> @@ -23,13 +23,18 @@
>  //
>  // The templated Callback class is a generalized function object. Together
>  // with the Bind() function in bind.h, they provide a type-safe method for
> -// performing currying of arguments, and creating a "closure."
> +// performing partial application of functions.
>  //
> -// In programming languages, a closure is a first-class function where
> all its
> -// parameters have been bound (usually via currying).  Closures are well
> -// suited for representing, and passing around a unit of delayed
> execution.
> -// They are used in Chromium code to schedule tasks on different
> MessageLoops.
> +// Partial application (or "currying") is the process of binding a subset
> of
> +// a function's arguments to produce another function that takes fewer
> +// arguments. This can be used to pass around a unit of delayed execution,
> +// much like lexical closures are used in other languages. For example, it
> +// is used in Chromium code to schedule tasks on different MessageLoops.
>  //
> +// A callback with no unbound input parameters
> (base::Callback<void(void)>)
> +// is called a base::Closure. Note that this is NOT the same as what other
> +// languages refer to as a closure -- it does not retain a reference to
> its
> +// enclosing environment.
>  //
>  // MEMORY MANAGEMENT AND PASSING
>  //
> @@ -270,7 +275,7 @@
>  // By default Bind() will store copies of all bound parameters, and
> attempt
>  // to refcount a target object if the function being bound is a class
> method.
>  // These copies are created even if the function takes parameters as const
> -// references. (Binding to non-const references is forbidden, see bind.h)
> +// references. (Binding to non-const references is forbidden, see bind.h.)
>  //
>  // To change this behavior, we introduce a set of argument wrappers
>  // (e.g., Unretained(), and ConstRef()).  These are simple container
> templates
> Index: base/callback.h.pump
> diff --git a/base/callback.h.pump b/base/callback.h.pump
> index e236254d8a3f85aa4a20d79b13f66f**631f416918..**
> 41d2ee9aecc9c2e3cc723adb7454b8**f215deabb6 100644
> --- a/base/callback.h.pump
> +++ b/base/callback.h.pump
> @@ -28,13 +28,18 @@ $var MAX_ARITY = 7
>  //
>  // The templated Callback class is a generalized function object. Together
>  // with the Bind() function in bind.h, they provide a type-safe method for
> -// performing currying of arguments, and creating a "closure."
> +// performing partial application of functions.
>  //
> -// In programming languages, a closure is a first-class function where
> all its
> -// parameters have been bound (usually via currying).  Closures are well
> -// suited for representing, and passing around a unit of delayed
> execution.
> -// They are used in Chromium code to schedule tasks on different
> MessageLoops.
> +// Partial application (or "currying") is the process of binding a subset
> of
> +// a function's arguments to produce another function that takes fewer
> +// arguments. This can be used to pass around a unit of delayed execution,
> +// much like lexical closures are used in other languages. For example, it
> +// is used in Chromium code to schedule tasks on different MessageLoops.
>  //
> +// A callback with no unbound input parameters
> (base::Callback<void(void)>)
> +// is called a base::Closure. Note that this is NOT the same as what other
> +// languages refer to as a closure -- it does not retain a reference to
> its
> +// enclosing environment.
>  //
>  // MEMORY MANAGEMENT AND PASSING
>  //
> @@ -274,6 +279,8 @@ $var MAX_ARITY = 7
>  //
>  // By default Bind() will store copies of all bound parameters, and
> attempt
>  // to refcount a target object if the function being bound is a class
> method.
> +// These copies are created even if the function takes parameters as const
> +// references. (Binding to non-const references is forbidden, see bind.h.)
>  //
>  // To change this behavior, we introduce a set of argument wrappers
>  // (e.g., Unretained(), and ConstRef()).  These are simple container
> templates
>
>
>

[commit-bot: I haz the power, 2012-12-06 12:40:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dubroy@chromium.org/11411319/1

[commit-bot: I haz the power, 2012-12-06 15:32:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dubroy@chromium.org/11411319/1

[commit-bot: I haz the power, 2012-12-06 19:00:57]

Change committed as 171549