Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 11411315: Add missing 'session->CloseIdleConnections()' in process_utils.cc (for Android). (Closed)

Created:
8 years ago by Philippe
Modified:
8 years ago
CC:
chromium-reviews, digit1
Visibility:
Public.

Description

Add missing 'session->CloseIdleConnections()' in process_utils.cc (for Android). CloseIdleConnectionsForProfile() was a no-op. It was only fetching the HttpNetworkSession for a specific profile but wasn't actually doing anything with it. The call to 'session->CloseIdleConnections()' got lost during the initial review process (see code review 10816038). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/android/process_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Philippe
8 years ago (2012-12-03 16:05:04 UTC) #1
aurimas (slooooooooow)
lgtm
8 years ago (2012-12-03 16:09:19 UTC) #2
Yaron
lgtm
8 years ago (2012-12-03 16:51:26 UTC) #3
Philippe
On 2012/12/03 16:51:26, Yaron wrote: > lgtm Thanks guys.
8 years ago (2012-12-03 16:54:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11411315/1
8 years ago (2012-12-03 16:54:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11411315/1
8 years ago (2012-12-03 18:50:26 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-03 22:10:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11411315/1
8 years ago (2012-12-04 08:58:46 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-04 11:57:31 UTC) #9
Message was sent while issue was closed.
Change committed as 170933

Powered by Google App Engine
This is Rietveld 408576698