Fixes wrong logic for display names.

Fixes wrong logic for display names.

- ui::GetOutputDeviceData() will return false if name is empty but it could be empty in case of internal display
- Now the display name is cached as a field of DisplayInfo struct, so the data could be empty.

BUG=163658
TEST=See chrome://settings/display on device


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170624

[oshima, 2012-11-30 20:28:59]

https://codereview.chromium.org/11411291/diff/1/ash/display/display_manager.cc
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/11411291/diff/1/ash/display/display_manager.c...
ash/display/display_manager.cc:564: continue;
so we don't have to create the entry for all outputs here?
just double checking.

[Jun Mukai, 2012-11-30 20:46:28]

https://codereview.chromium.org/11411291/diff/1/ash/display/display_manager.cc
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/11411291/diff/1/ash/display/display_manager.c...
ash/display/display_manager.cc:564: continue;
On 2012/11/30 20:28:59, oshima wrote:
> so we don't have to create the entry for all outputs here?
> just double checking.

Good point. Removed this if. Sometimes the device returns empty outputs and I
wanted to skip such case, but anyway its name is empty so they'll be just
ignored below.

[oshima, 2012-11-30 21:07:17]

lgtm

[Jun Mukai, 2012-11-30 21:16:40]

Oops, missing comments.  derat, please do the OWNER review.
thanks!

[Jun Mukai, 2012-11-30 21:55:59]

james, could you review this?  I asked derat for owner review but it seems that
he's unavailable today.

[James Cook, 2012-11-30 23:23:44]

lgtm

[commit-bot: I haz the power, 2012-11-30 23:28:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11411291/4

[commit-bot: I haz the power, 2012-12-01 01:49:31]

Change committed as 170624