Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 11411283: Fix the scale pivot for views corewm hide window animations. (Closed)

Created:
8 years ago by Ian Vollick
Modified:
8 years ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix the scale pivot for views corewm hide window animations. Right now, we use 0.025 * bounds as the pivot, which basically amounts to the upper left corner of the window. I don't think that was intended. I think that we mean to scale about the center of the window when hiding. BUG=163385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/corewm/window_animations.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Ian Vollick
8 years ago (2012-11-30 13:23:02 UTC) #1
sadrul
The values doesn't seem to have changed recently. Did something else change that introduced the ...
8 years ago (2012-11-30 16:49:09 UTC) #2
Ian Vollick
On 2012/11/30 16:49:09, sadrul wrote: > The values doesn't seem to have changed recently. Did ...
8 years ago (2012-11-30 16:59:53 UTC) #3
sadrul
On 2012/11/30 16:59:53, vollick wrote: > On 2012/11/30 16:49:09, sadrul wrote: > > The values ...
8 years ago (2012-11-30 17:03:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/11411283/1
8 years ago (2012-11-30 17:48:59 UTC) #5
commit-bot: I haz the power
8 years ago (2012-11-30 19:55:18 UTC) #6
Message was sent while issue was closed.
Change committed as 170515

Powered by Google App Engine
This is Rietveld 408576698