Immersive mode reveals the tabstrip/omnibox on top of web content

Immersive mode reveals the tabstrip/omnibox on top of web content

ImmersiveModeController reparents the tabstrip and toolbar to a new RevealView
during the slide-down reveal of the top views. This allows the view hierarchy
in the non-immersive-mode case to remain as it is, reducing the likelihood this
change will break Windows.

BrowserViewLayout stops caching pointers to tabstrip and toolbar as it can
access them directly from BrowserView.

BUG=162310
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170385

[James Cook, 2012-11-29 17:36:16]

Sky, PTAL.  I like this approach because it doesn't change the behavior for
Windows. This should isolate bugs with things like accessibility to immersive
mode, and specifically to the reveal state.  It also gives me an easy way to
transiently put the view/layer on top.

(There are a couple of known issues with this - it doesn't yet support
bookmarks, but I wanted to get an early evaluation of the approach.)

[sky, 2012-11-29 19:30:23]

In general this seems fine, just a couple of specific questions.

https://codereview.chromium.org/11411250/diff/1013/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/browser_view.h (right):

https://codereview.chromium.org/11411250/diff/1013/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/browser_view.h:610: //
Can you also add a comment about reveal mode.

https://codereview.chromium.org/11411250/diff/1013/chrome/browser/ui/views/im...
File chrome/browser/ui/views/immersive_mode_controller.cc (right):

https://codereview.chromium.org/11411250/diff/1013/chrome/browser/ui/views/im...
chrome/browser/ui/views/immersive_mode_controller.cc:118: frame->Paint(canvas);
Won't this try to paint all the children of the frame too? Do you really want
that?

[James Cook, 2012-11-29 21:20:58]

PTAL

https://codereview.chromium.org/11411250/diff/1013/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/browser_view.h (right):

https://codereview.chromium.org/11411250/diff/1013/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/browser_view.h:610: //
On 2012/11/29 19:30:23, sky wrote:
> Can you also add a comment about reveal mode.

Done.

https://codereview.chromium.org/11411250/diff/1013/chrome/browser/ui/views/im...
File chrome/browser/ui/views/immersive_mode_controller.cc (right):

https://codereview.chromium.org/11411250/diff/1013/chrome/browser/ui/views/im...
chrome/browser/ui/views/immersive_mode_controller.cc:118: frame->Paint(canvas);
On 2012/11/29 19:30:23, sky wrote:
> Won't this try to paint all the children of the frame too? Do you really want
> that?

I need all the children of the frame view to be painted to get the close and
maximized button to draw.  frame()->GetFrameView() gives me the
BrowserNonClientFrameView and NonClientFrameView is a sibling of the ClientView,
so painting it should not repaint BrowserView, just the frame stuff.

[sky, 2012-11-29 22:39:00]

LGTM

[commit-bot: I haz the power, 2012-11-30 01:01:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/11411250/10001

[commit-bot: I haz the power, 2012-11-30 03:44:47]

Change committed as 170385