Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: runtime/platform/floating_point_win.cc

Issue 11411188: Fix floating point issues on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: ndx_x, ndx_y -> index_x, index_y. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/platform/floating_point_win.h ('k') | runtime/platform/globals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/platform/floating_point_win.cc
diff --git a/runtime/platform/floating_point_win.cc b/runtime/platform/floating_point_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..82aee167edd2d03e4c07d937aae89cc970703db7
--- /dev/null
+++ b/runtime/platform/floating_point_win.cc
@@ -0,0 +1,46 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#include <math.h>
+#include <limits>
+
+#include "platform/globals.h"
+
+// Taken from third_party/v8/src/platform-win32.cc
+double fmod_ieee(double x, double y) {
+ // x is dividend, y is divisor.
+ // Work around MS fmod bugs. ISO Standard says:
+ // If dividend is finite and divisor is an infinity or
+ // dividend is a zero and divisor is nonzero finite,
+ // then dividend is returned.
+ if (!(_finite(x) && (!_finite(y) && !isnan(y))) &&
+ !(x == 0 && (y != 0 && _finite(y)))) {
+ x = fmod(x, y);
+ }
+ return x;
+}
+
+// Bring MSVC atan2 behavior in line with ISO standard.
+// MSVC atan2 returns NaN when x and y are either +infinity or -infinity.
+// Per ISO standard:
+// - If y is +/-infinity and x is -infinity, +/-3*pi/4 is returned.
+// - If y is +/-infinity and x is +infinity, +/-pi/4 is returned.
+double atan2_ieee(double x, double y) {
+ int cls_x = _fpclass(x);
+ int cls_y = _fpclass(y);
+ if (((cls_x & (_FPCLASS_PINF | _FPCLASS_NINF)) != 0) &&
+ ((cls_y & (_FPCLASS_PINF | _FPCLASS_NINF)) != 0)) {
+ // atan2 values at infinities listed above are the same as values
+ // at (+/-1, +/-1). index_x is 0, when x is +infinty, 1 when x is -infinty.
+ // Same is with index_y.
+ int index_x = (cls_x & _FPCLASS_PINF) != 0 ? 0 : 1;
+ int index_y = (cls_y & _FPCLASS_PINF) != 0 ? 0 : 1;
+ static double atans_at_infinities[2][2] =
+ { { atan2(1., 1.), atan2(1., -1.) },
+ { atan2(-1., 1.), atan2(-1., -1.) } };
+ return atans_at_infinities[index_x][index_y];
+ } else {
+ return atan2(x, y);
+ }
+}
« no previous file with comments | « runtime/platform/floating_point_win.h ('k') | runtime/platform/globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698