Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 11411183: Move processes API function registration out of ExtensionFunctionRegistry. (Closed)

Created:
8 years ago by Yoyo Zhou
Modified:
8 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move processes API function registration out of ExtensionFunctionRegistry. BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/extensions/api/processes/processes_api.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoyo Zhou
What do you think? Since it's harmless to register the same function more than once ...
8 years ago (2012-11-26 23:16:10 UTC) #1
Yoyo Zhou
Ping?
8 years ago (2012-12-01 01:02:51 UTC) #2
Aaron Boodman
Should there be a more proper way to do things once per process? Should EFR ...
8 years ago (2012-12-01 01:53:17 UTC) #3
Yoyo Zhou
Aaron, is there someone else I should get to review this? On 2012/12/01 01:53:17, Aaron ...
8 years ago (2012-12-04 19:40:06 UTC) #4
Yoyo Zhou
redirecting to mpcomplete
8 years ago (2012-12-04 21:28:39 UTC) #5
Matt Perry
lgtm
8 years ago (2012-12-04 21:49:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/11411183/1
8 years ago (2012-12-04 23:00:49 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-05 02:17:44 UTC) #8
Message was sent while issue was closed.
Change committed as 171123

Powered by Google App Engine
This is Rietveld 408576698