Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/favicon/favicon_download_helper.cc

Issue 11411180: move favicon download code from chrome/ into content/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_download_helper.cc
diff --git a/chrome/browser/favicon/favicon_download_helper.cc b/chrome/browser/favicon/favicon_download_helper.cc
index ce3959fcc417ca4941fc0f1aaaf831269253147c..82d54edd79afee01e438a46c3e7bb83942f7aa7d 100644
--- a/chrome/browser/favicon/favicon_download_helper.cc
+++ b/chrome/browser/favicon/favicon_download_helper.cc
@@ -5,14 +5,18 @@
#include "chrome/browser/favicon/favicon_download_helper.h"
#include "chrome/browser/favicon/favicon_download_helper_delegate.h"
-#include "chrome/browser/favicon/favicon_util.h"
#include "chrome/common/icon_messages.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_delegate.h"
+using content::FaviconURL;
using content::WebContents;
+namespace {
+ static int current_download_id = 0;
+} // namespace.
+
FaviconDownloadHelper::FaviconDownloadHelper(
WebContents* web_contents,
FaviconDownloadHelperDelegate* delegate)
@@ -26,7 +30,9 @@ FaviconDownloadHelper::~FaviconDownloadHelper() {
int FaviconDownloadHelper::DownloadFavicon(const GURL& url, int image_size) {
content::RenderViewHost* host = web_contents()->GetRenderViewHost();
- int id = FaviconUtil::DownloadFavicon(host, url, image_size);
+ int id = ++current_download_id;
+ host->Send(new IconMsg_DownloadFavicon(host->GetRoutingID(), id, url,
jam 2012/11/27 01:16:31 is this file wrong? i.e. icon_messages.h is now in
Cait (Slow) 2012/11/28 00:11:45 Done.
+ image_size));
DownloadIdList::iterator i =
std::find(download_ids_.begin(), download_ids_.end(), id);
DCHECK(i == download_ids_.end());

Powered by Google App Engine
This is Rietveld 408576698