Implemented BluetoothTaskManagerWin class.

device/bluetooth/bluetooth_adapter_win.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_WIN_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_WIN_H_
 
 #include <string>
 
+#include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
+#include "base/threading/thread_checker.h"
 #include "device/bluetooth/bluetooth_adapter.h"
+#include "device/bluetooth/bluetooth_polling_thread_win.h"
+
+namespace base {
+
+class ThreadChecker;

[bryeung, 2012/11/28 16:26:08]

no longer necessary now that you have the header included

[youngki, 2012/11/28 19:19:13]

Done.

+
+}  // namespace base
 
 namespace device {
 
 class BluetoothAdapterFactory;
 class BluetoothAdapterWinTest;
 class BluetoothDevice;
 
-class BluetoothAdapterWin : public BluetoothAdapter {
+class BluetoothAdapterWin : public BluetoothAdapter,
+                            private BluetoothPollingThreadWin::Observer {
  public:
   // BluetoothAdapter override
   virtual void AddObserver(BluetoothAdapter::Observer* observer) OVERRIDE;
   virtual void RemoveObserver(BluetoothAdapter::Observer* observer) OVERRIDE;
   virtual bool IsPresent() const OVERRIDE;
   virtual bool IsPowered() const OVERRIDE;
   virtual void SetPowered(
       bool powered,
       const base::Closure& callback,
       const ErrorCallback& error_callback) OVERRIDE;
   virtual bool IsDiscovering() const OVERRIDE;
   virtual void SetDiscovering(
       bool discovering,
       const base::Closure& callback,
       const ErrorCallback& error_callback) OVERRIDE;
   virtual ConstDeviceList GetDevices() const OVERRIDE;
   virtual BluetoothDevice* GetDevice(const std::string& address) OVERRIDE;
   virtual const BluetoothDevice* GetDevice(
       const std::string& address) const OVERRIDE;
   virtual void ReadLocalOutOfBandPairingData(
       const BluetoothOutOfBandPairingDataCallback& callback,
       const ErrorCallback& error_callback) OVERRIDE;
 
+  void SetBluetoothPollingThreadForTest(BluetoothPollingThreadWin* manager);
+
  protected:
   BluetoothAdapterWin();
   virtual ~BluetoothAdapterWin();
 
-  virtual void UpdateAdapterState();
-
  private:
   friend class BluetoothAdapterFactory;
   friend class BluetoothAdapterWinTest;
 
-  // Obtains the default adapter info (the first bluetooth radio info found on
-  // the system) and tracks future changes to it.
+  // BluetoothPollingThreadWin::Observer override
+  virtual void AdapterStateChanged(
+      const BluetoothPollingThreadWin::AdapterState& state) OVERRIDE;
+
+  // Starts BluetoothPollingThreadWin thread to obtain the default adapter info.
   void TrackDefaultAdapter();
 
-  void PollAdapterState();
-
-  static const int kPollIntervalMs;
-
   bool powered_;
 
+  // Holding scoped_ptr guarantees that BluetoothAdapterWin will always outlive
+  // BluetoothPollingThreadWin thread.
+  scoped_ptr<BluetoothPollingThreadWin> thread_;

[bryeung, 2012/11/28 16:26:08]

it occurs to me that you could get an equivalently good guarantee by just making
this a value member as well :-)

[youngki, 2012/11/28 19:19:13]

My only concern is testing; I was going to replace this with
MockBluetoothPollingThreadWin for unittest, and if I make this a value I don't
know how I could effectively test this class.

+
+  base::ThreadChecker thread_checker_;
+
   // NOTE: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.
   base::WeakPtrFactory<BluetoothAdapterWin> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothAdapterWin);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_WIN_H_